Page MenuHomeFreeBSD
Differential D31584

gre: simplify RSS ifdefs
ClosedPublic
Actions

Authored by • franco_opnsense.org on Aug 17 2021, 9:43 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 1, 12:54 AM
Unknown Object (File)
Sat, Mar 28, 9:11 PM
Unknown Object (File)
Mon, Mar 23, 6:47 AM
Unknown Object (File)
Thu, Mar 19, 7:13 PM
Unknown Object (File)
Tue, Mar 17, 11:17 PM
Unknown Object (File)
Thu, Mar 5, 7:14 PM
Unknown Object (File)
Mar 4 2026, 5:39 AM
Unknown Object (File)
Mar 4 2026, 5:26 AM
View All Files
Subscribers
ae
imp
melifaro
Contributor Reviews (src)

Details

Reviewers
kbowling
melifaro
Commits
rG5e2076065c8b: gre: simplify RSS ifdefs
rG412a609da482: gre: simplify RSS ifdefs
rGbb250fae9e9e: gre: simplify RSS ifdefs
Summary

Use the early break to avoid else definitions. When RSS gains a
runtime option previous constructs would duplicate and convolute
the existing code.

While here init flowid and skip magic numbers and late default
assignment.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• franco_opnsense.org created this revision.Aug 17 2021, 9:43 AM
Herald added subscribers: Contributor Reviews (src), melifaro, ae, imp. · View Herald TranscriptAug 17 2021, 9:43 AM
• franco_opnsense.org requested review of this revision.Aug 17 2021, 9:43 AM
Harbormaster completed remote builds in B41096: Diff 93818.Aug 17 2021, 9:43 AM
melifaro added inline comments.Aug 17 2021, 11:20 AM
sys/net/if_gre.c
658

this one always wins

• franco_opnsense.org added inline comments.Aug 17 2021, 11:48 AM
sys/net/if_gre.c
658

no, RSS inserts an early break statement above

kbowling accepted this revision.Aug 18 2021, 7:24 AM
This revision is now accepted and ready to land.Aug 18 2021, 7:24 AM
melifaro accepted this revision.Aug 18 2021, 7:56 AM
Closed by commit rGbb250fae9e9e: gre: simplify RSS ifdefs (authored by • franco_opnsense.org, committed by Kevin Bowling <kbowling@FreeBSD.org>). · Explain WhyAug 18 2021, 5:09 PM
This revision was automatically updated to reflect the committed changes.
Kevin Bowling <kbowling@FreeBSD.org> added a commit: rGbb250fae9e9e: gre: simplify RSS ifdefs.
Kevin Bowling <kbowling@FreeBSD.org> added a commit: rG412a609da482: gre: simplify RSS ifdefs.Aug 25 2021, 11:53 PM
Kevin Bowling <kbowling@FreeBSD.org> added a commit: rG5e2076065c8b: gre: simplify RSS ifdefs.Aug 26 2021, 12:04 AM

Revision Contents
Changeset List

PathSize
sys/
net/
35 lines

Diff 93892

View Options

sys/net/if_gre.c

Loading...