LGTM.

What!? I can't run my SCO executables anymore?

Closed in r331665

ping?

per @matthew

In D15386#334600, @rwatson wrote:

Rather than using raw integer types, I wonder if we should introduce new FreeBSD types -- e.g., ksize_t, kptr_t -- that wrap them, instead? They would still all map through to int64_t/uint64_t as required, but if we needed to change this in the future, we could do so more easily.

What do y'all think of making the username the maximum length username seen so far (up until a fixed max). This solves all known issues

• having to short username
• having too long username
• initialization being slow since it needs to iterate over a remote service
• having the column flicker due to a long username going in and out of use.

In D15801#334174, @danfe wrote:

In D15801#334140, @allanjude wrote:

Why would you reduce the username field from 13-15 down to 8 characters? There are plenty of usernames of 8-12+ characters on my systems

Apparently you've missed this email of mine. TL;DR: Because most of the usernames (on most systems) are 8 characters or less. E

I tested it. It works. Thanks!

In D15768#333253, @araujo wrote:

In D15768#333252, @rgrimes wrote:

It is normal to separate all whitespace changes from other. It is preferable to separate all SPDX changes from others when it is sweeping. I strongly assert that as the person now cleaning up a 180k lines and 16 commits of diff involving SPDX tags that this separation occur before this is commited.

Sorry, I strongly disagree, I would need to make two reviews and two commits that can be done at once and there is no functional changes.

The commit log easily can describe these changes:

• Fix style(9) space vs tab.
• Add SPDX tag on those files that didn't have it.

I'm inclined to listen to the reviewers advice that I added, if that is mandatory, I will do, otherwise I can't see any problem to have these changes in one commit.