Page MenuHomeFreeBSD
Feed Advanced Search

Nov 11 2020

val_packett.cool requested review of D27180: uaudio: add sysctl hw.usb.uaudio.handle_hid to allow disabling HID volume keys support.
Nov 11 2020, 5:56 PM

Nov 10 2020

val_packett.cool requested review of D27158: Allow rtprio_thread to operate on threads of any process.
Nov 10 2020, 12:44 AM

Nov 9 2020

val_packett.cool retitled D26668: Expose eventfd in the native API/ABI using a new __specialfd syscall from Add native system call for eventfd to Expose eventfd in the native API/ABI using a new __specialfd syscall.
Nov 9 2020, 4:41 PM · Linux Emulation
val_packett.cool added a comment to D26668: Expose eventfd in the native API/ABI using a new __specialfd syscall.

Now named with the __ convention and using libc_private (didn't know about it).

Nov 9 2020, 4:40 PM · Linux Emulation
val_packett.cool updated the diff for D26668: Expose eventfd in the native API/ABI using a new __specialfd syscall.
Nov 9 2020, 4:38 PM · Linux Emulation

Nov 6 2020

val_packett.cool updated the diff for D26668: Expose eventfd in the native API/ABI using a new __specialfd syscall.

Added specialfd. Okay, that doesn't look too bad. I haven't tested intentionally causing problems from userspace, but other syscalls seem to be doing the same thing as here with user structs, I guess everything that could go wrong is handled inside copyin?

Nov 6 2020, 10:23 PM · Linux Emulation
val_packett.cool added a comment to D27113: Only try to retrieve UUID from SMBIOS on x86 machines.

Server-class arm64 machines also have SMBIOS data present. Maybe just condition the actual warning print to amd64 | i386 but try it everywhere?

Nov 6 2020, 4:28 PM
val_packett.cool added a comment to D26668: Expose eventfd in the native API/ABI using a new __specialfd syscall.

Another thing. That syscall, would it have to be documented? Or would it be okay to pretend that we have the eventfd(2) "system call" when in reality it's a libc function calling into a private specialfd system call?

Nov 6 2020, 12:39 PM · Linux Emulation

Nov 5 2020

val_packett.cool added a comment to D26668: Expose eventfd in the native API/ABI using a new __specialfd syscall.
In D26668#604707, @kib wrote:

So where we are WRT extending syscall to make it reusable for timerfd ?

Nov 5 2020, 6:48 PM · Linux Emulation

Nov 3 2020

val_packett.cool added a comment to D23085: DRM: Add DRM core files and DRMKPI.

I think that having one single codebase, fully based on GPL code for fast porting, is a MUCH more important goal than having display output without GPL (/in base).

Nov 3 2020, 7:12 PM

Oct 23 2020

val_packett.cool updated the diff for D22960: New ports for WebAssembly System Interface (WASI) libc, clang builtins (compiler-rt), libc++, libcxxabi.

oops, also ranlib cxxabi

Oct 23 2020, 4:16 PM
val_packett.cool updated the diff for D22960: New ports for WebAssembly System Interface (WASI) libc, clang builtins (compiler-rt), libc++, libcxxabi.
  • Update to LLVM 11 and latest wasi-libc
  • libc++ now only supports building from the llvm monorepo
  • I've integrated the libc++abi build into the libc++ port to avoid extracting the monorepo a whole extra time for the tiny libc++abi build
  • Removed version suffix from the libc++ port since it installs into an unversioned ${PREFIX}/share/wasi-sysroot
Oct 23 2020, 4:06 PM

Oct 18 2020

val_packett.cool added inline comments to D26836: linsysfs: add drm render node.
Oct 18 2020, 10:52 PM
val_packett.cool requested review of D26836: linsysfs: add drm render node.
Oct 18 2020, 2:34 PM

Oct 17 2020

val_packett.cool updated the diff for D26668: Expose eventfd in the native API/ABI using a new __specialfd syscall.

Address feedback

Oct 17 2020, 1:13 PM · Linux Emulation
val_packett.cool added inline comments to D26668: Expose eventfd in the native API/ABI using a new __specialfd syscall.
Oct 17 2020, 1:12 PM · Linux Emulation
val_packett.cool added a comment to D26668: Expose eventfd in the native API/ABI using a new __specialfd syscall.

But then the functionality of libc wrapper would have to be reimplemented in the kernel anyway, for the purpose of linuxulator.

Oct 17 2020, 12:59 PM · Linux Emulation
val_packett.cool added a comment to D26668: Expose eventfd in the native API/ABI using a new __specialfd syscall.

Or it might be that I'm entirely out of sync with this discussion; if the public interface is compatible with Linux, then I'm happy :-)

Oct 17 2020, 1:07 AM · Linux Emulation

Oct 16 2020

val_packett.cool added a comment to D26668: Expose eventfd in the native API/ABI using a new __specialfd syscall.

No, please, let's keep it compatible with the rest of the world (ie Linux). Otherwise we'll only creating more work for Ports folks for no good reason.

Oct 16 2020, 9:50 PM · Linux Emulation
val_packett.cool added inline comments to D26810: Mark asymmetric cryptography via OCF deprecated for 14.0..
Oct 16 2020, 11:52 AM

Oct 14 2020

val_packett.cool added a comment to D26668: Expose eventfd in the native API/ABI using a new __specialfd syscall.
In D26668#596865, @kib wrote:

Could we get away with /dev/eventfd, which would return eventfd on open ? Libc wrapper then handles compat for eventfd(2).

Oct 14 2020, 1:25 AM · Linux Emulation

Oct 13 2020

val_packett.cool updated the diff for D26668: Expose eventfd in the native API/ABI using a new __specialfd syscall.

Fix mandoc lint

Oct 13 2020, 4:40 PM · Linux Emulation
val_packett.cool updated the diff for D26668: Expose eventfd in the native API/ABI using a new __specialfd syscall.
Oct 13 2020, 2:20 PM · Linux Emulation
val_packett.cool added inline comments to D26668: Expose eventfd in the native API/ABI using a new __specialfd syscall.
Oct 13 2020, 2:14 PM · Linux Emulation

Oct 8 2020

val_packett.cool updated the diff for D26668: Expose eventfd in the native API/ABI using a new __specialfd syscall.
  • Cleaned various things up (based on feedback)
  • Added kqueue filter data (hopefully the casts are fine)
  • Switched constants to O_ native ones
  • Changed stat to non-error (same as the impl for kqueue)
  • Moved libc extra functions to the gen subdirectory (this was the feedback in D2172)
  • Added manpage (written from scratch to avoid licensing issues)
  • Added audit stuff
  • Added procstat stuff
Oct 8 2020, 11:22 PM · Linux Emulation
val_packett.cool added inline comments to D26668: Expose eventfd in the native API/ABI using a new __specialfd syscall.
Oct 8 2020, 12:07 PM · Linux Emulation
val_packett.cool added inline comments to D26668: Expose eventfd in the native API/ABI using a new __specialfd syscall.
Oct 8 2020, 11:44 AM · Linux Emulation
val_packett.cool added inline comments to D26668: Expose eventfd in the native API/ABI using a new __specialfd syscall.
Oct 8 2020, 11:13 AM · Linux Emulation
val_packett.cool added inline comments to D26668: Expose eventfd in the native API/ABI using a new __specialfd syscall.
Oct 8 2020, 11:10 AM · Linux Emulation

Oct 7 2020

val_packett.cool added a member for linuxkpi: val_packett.cool.
Oct 7 2020, 9:46 PM
val_packett.cool added a member for arm64: val_packett.cool.
Oct 7 2020, 9:46 PM
val_packett.cool added a member for rust: val_packett.cool.
Oct 7 2020, 9:45 PM

Oct 6 2020

val_packett.cool added a comment to D26668: Expose eventfd in the native API/ABI using a new __specialfd syscall.

Or we can keep providing our own, well-designed and implemented set of interfaces instead of copying silly syscalls from Linux. I'd much rather fix linuxisms in software than pollute our kernel.

Oct 6 2020, 10:36 AM · Linux Emulation

Oct 4 2020

val_packett.cool requested review of D26668: Expose eventfd in the native API/ABI using a new __specialfd syscall.
Oct 4 2020, 8:06 PM · Linux Emulation
val_packett.cool added inline comments to D21863: ugensa: add support for Google Cr50 (GSC) Closed Case Debugging UART interfaces.
Oct 4 2020, 4:54 PM
val_packett.cool requested review of D26657: linuxkpi: populate the acquire context field of a ww_mutex.
Oct 4 2020, 1:50 PM · linuxkpi

Oct 2 2020

val_packett.cool added inline comments to D26642: Add DTYPE/KF_TYPE and procstat support for dma-buf.
Oct 2 2020, 7:47 PM
val_packett.cool requested review of D26642: Add DTYPE/KF_TYPE and procstat support for dma-buf.
Oct 2 2020, 11:23 AM
val_packett.cool created P431 dmabuf dtype drm patch.
Oct 2 2020, 10:59 AM

Oct 1 2020

val_packett.cool added inline comments to D21863: ugensa: add support for Google Cr50 (GSC) Closed Case Debugging UART interfaces.
Oct 1 2020, 4:22 PM
val_packett.cool added a comment to D21863: ugensa: add support for Google Cr50 (GSC) Closed Case Debugging UART interfaces.

@hselasky ping

Oct 1 2020, 4:00 PM
val_packett.cool added a reviewer for D25260: ichsmb_pci: convert to pci_device_table / add PCI_PNP_INFO: manu.
Oct 1 2020, 3:58 PM
val_packett.cool requested review of D26630: Update pygobject3.
Oct 1 2020, 3:57 PM

Sep 27 2020

val_packett.cool added a comment to D18754: sysutils/consolekit2: enable drm/evdev, fix drm device recognition.

Yeah, CK2 has been abandoned for quite some time.

Sep 27 2020, 1:11 AM

Sep 26 2020

val_packett.cool added inline comments to D25219: ACPI: add support for (inherited) _DMA limits.
Sep 26 2020, 9:08 AM · arm64

Sep 25 2020

val_packett.cool added a comment to D26555: gitignore: Add .clangd and .ccls-cache.

Ideally everyone would keep that kind of stuff in their global gitignore (core.excludesfile) :)

Sep 25 2020, 11:50 AM

Sep 15 2020

val_packett.cool added inline comments to D26439: devel/gobject-introspection: update to 1.66.0.
Sep 15 2020, 4:53 PM
val_packett.cool added inline comments to D26435: Add rtsx driver for Realtek SD card readers..
Sep 15 2020, 11:18 AM

Sep 12 2020

val_packett.cool accepted D26415: x11-toolkits/qt5-gtkplatform: fix build.

Probably also worth deprecating maybe.

Sep 12 2020, 10:08 PM

Sep 11 2020

val_packett.cool added inline comments to D26252: Add pwm_backlight.
Sep 11 2020, 1:24 PM
val_packett.cool added inline comments to D26137: Wireguard merge.
Sep 11 2020, 12:55 PM

Sep 10 2020

val_packett.cool added a comment to D26362: Move some gnome@ ports to desktop@.

Oh, also, x11-toolkits/libhandy should be added to the list.

Sep 10 2020, 11:29 AM

Sep 9 2020

val_packett.cool added inline comments to D26250: Add backlight subsystem.
Sep 9 2020, 3:11 PM
val_packett.cool added a comment to D26362: Move some gnome@ ports to desktop@.

Wow, what is devel/meson of all things doing in gnome? (and devel/cmake, devel/ninja in kde, for that matter)

Sep 9 2020, 3:06 PM

Sep 4 2020

val_packett.cool added a comment to D24933: implement W^X for mmap and mprotect.

So far, the only thing that doesn't work for me with W^X is GJS..

Sep 4 2020, 5:59 PM
val_packett.cool added inline comments to D26250: Add backlight subsystem.
Sep 4 2020, 5:19 PM

Sep 3 2020

val_packett.cool added inline comments to D26251: Add backlight(8).
Sep 3 2020, 12:29 PM

Aug 23 2020

val_packett.cool added a reviewer for D24423: arm/pmu: add ACPI attachment: gonzo.
Aug 23 2020, 1:16 PM · arm64

Aug 22 2020

val_packett.cool added a comment to D25145: acpi_resource: support multiple IRQs.

ping

Aug 22 2020, 9:55 AM · arm64
val_packett.cool added a comment to D25179: acpi_iort: fix mapping end calculation.

@andrew ping

Aug 22 2020, 9:19 AM · arm64
val_packett.cool added a comment to D25260: ichsmb_pci: convert to pci_device_table / add PCI_PNP_INFO.

ping.. can anyone commit?

Aug 22 2020, 9:11 AM

Aug 16 2020

val_packett.cool added inline comments to D26072: Add support for PMU on SMP systems for ARM64.
Aug 16 2020, 5:08 PM

Aug 7 2020

val_packett.cool added a comment to D24255: Allow flock() on fifos.
In D24255#575592, @mjg wrote:

Hi. Do you need help updating the patch? I can do the necessary changes.

Aug 7 2020, 12:28 AM

Aug 1 2020

val_packett.cool accepted D25899: graphics/webp-pixbuf-loader: Update to 0.0.1 -> stage_fs_violation.

I just still don't know why the cache was apparently being updated before but this is something I can investigate later.

Aug 1 2020, 8:02 PM

Jul 31 2020

val_packett.cool added inline comments to D25899: graphics/webp-pixbuf-loader: Update to 0.0.1 -> stage_fs_violation.
Jul 31 2020, 11:25 PM
val_packett.cool added inline comments to D25899: graphics/webp-pixbuf-loader: Update to 0.0.1 -> stage_fs_violation.
Jul 31 2020, 3:43 PM
val_packett.cool added a comment to D25899: graphics/webp-pixbuf-loader: Update to 0.0.1 -> stage_fs_violation.

No, no, please read this carefully again:

Jul 31 2020, 11:55 AM
val_packett.cool added a comment to D25830: Basic ifconfig support for wireguard.

It currently lacks support for changing keys or deleting peers as the wg(9) supports

Jul 31 2020, 10:45 AM
val_packett.cool added a comment to D25899: graphics/webp-pixbuf-loader: Update to 0.0.1 -> stage_fs_violation.

unfortunatelly there is a need to use PORTEPOCH

Jul 31 2020, 10:17 AM

Jul 28 2020

val_packett.cool added a comment to D25839: efibootmgr: Add option to request booting to the firmware user interface.
In D25839#572447, @manu wrote:

I didn't knew this features, looks useful, is the variable reset by the firmware ? (Or at least is supposed to be ?)

Jul 28 2020, 10:39 AM

Jul 17 2020

val_packett.cool accepted D25704: Fix L2CAP ACL packet Packet Boundary flag for LE packet..

It's a bit funny that the check is == NG_HCI_LINK_ACL (we are speaking ACL anyway), but makes sense — with LE it would be NG_HCI_LINK_LE_PUBLIC / NG_HCI_LINK_LE_RANDOM, and others like SCO wouldn't be used with L2CAP (?)

Jul 17 2020, 11:53 AM

Jul 16 2020

val_packett.cool added a comment to D25690: Allow Bluetooth HCI raw sockets to send ACL/SCO data.
In D25690#568607, @emax wrote:

can you please explain why using l2cap socket is not good enough?

Jul 16 2020, 7:26 PM
val_packett.cool requested review of D25690: Allow Bluetooth HCI raw sockets to send ACL/SCO data.
Jul 16 2020, 5:35 PM

Jul 14 2020

val_packett.cool added inline comments to D25665: DMAR split-out (part 2).
Jul 14 2020, 5:18 PM

Jul 12 2020

val_packett.cool added inline comments to D25629: Loader: explain currdev syntax.
Jul 12 2020, 11:00 AM

Jul 8 2020

val_packett.cool added a comment to D25587: geli: enable direct dispatch.

I haven't been able to test it with a hardware crypto accelerator.

Jul 8 2020, 4:45 PM

Jul 6 2020

val_packett.cool added a comment to D25552: kern_cpuset: allow using the explicit form of own pid/tid in capability mode.
  • these checks should really be lifted into a subroutine,
Jul 6 2020, 2:36 PM · capsicum

Jul 5 2020

val_packett.cool added a comment to D25373: Fix AccessWidth and BitWidth parsing in SPCR table.

ECAM hacks? When are those likely to appear? :-)

Jul 5 2020, 3:30 PM · x86, arm64

Jul 4 2020

val_packett.cool added a comment to D24255: Allow flock() on fifos.
In D24255#565138, @mjg wrote:

I agree with the patch. What line would like to see in "submitted by"?

Jul 4 2020, 1:42 PM
val_packett.cool added a comment to D24255: Allow flock() on fifos.

ping

Jul 4 2020, 11:15 AM
val_packett.cool added a reviewer for D25552: kern_cpuset: allow using the explicit form of own pid/tid in capability mode: markj.
Jul 4 2020, 11:12 AM · capsicum

Jul 2 2020

val_packett.cool requested review of D25552: kern_cpuset: allow using the explicit form of own pid/tid in capability mode.
Jul 2 2020, 8:12 PM · capsicum

Jun 30 2020

val_packett.cool added inline comments to D25525: Add timerisvalid() from OpenBSD.
Jun 30 2020, 10:21 PM
val_packett.cool added a comment to D25509: LinuxKPI: support thread IDs in linux_task_exiting.

Change looks good! Do you need help submitting?

Jun 30 2020, 5:30 PM

Jun 29 2020

val_packett.cool requested review of D25509: LinuxKPI: support thread IDs in linux_task_exiting.
Jun 29 2020, 9:19 PM

Jun 26 2020

val_packett.cool added a comment to D24400: Make encrypted swap more reliable.

This needs rebase now after the zeroing changes

Jun 26 2020, 3:55 PM

Jun 23 2020

val_packett.cool updated the diff for D21863: ugensa: add support for Google Cr50 (GSC) Closed Case Debugging UART interfaces.

The clear stall quirk is not necessary anymore (since cr50 firmware 0.3.24), so let's just recognize the device.

Jun 23 2020, 4:51 PM
val_packett.cool updated the diff for D20835: aarch64: enable tagged pointers (TBI — Top Byte Ignored).

Rebased.

Jun 23 2020, 2:06 PM · arm64
val_packett.cool requested review of D25411: arm64 armreg.h: fix TCR_TBI1 definition.
Jun 23 2020, 2:05 PM · arm64
val_packett.cool added a comment to D24787: Link efi programs with -pie rather than -shared.
In D24787#550414, @greg_unrelenting.technology wrote:

Looks like this breaks aarch64, I got a "Synchronous exception" after the loader detects filesystems. Rebuilding after reverting the change fixed it.

Does this fix it? https://github.com/CTSRD-CHERI/cheribsd/commit/ef7b5749427620d6ee1c9834ea6a264f816e99ea

Jun 23 2020, 12:21 PM
val_packett.cool accepted D25373: Fix AccessWidth and BitWidth parsing in SPCR table.

Works on my mcbin with the official SPCR table! :) Might test on other things later.

Jun 23 2020, 12:13 PM · x86, arm64
val_packett.cool updated the diff for D25201: Use EFI memory map to determine attributes for AcpiOsMapMemory mappings on arm64.
Jun 23 2020, 9:48 AM · arm64
val_packett.cool requested review of D25390: atkbd/evdev: recognize the Chromebook menu key as F13 like Linux does.
Jun 23 2020, 3:22 AM
val_packett.cool updated the diff for D25179: acpi_iort: fix mapping end calculation.

Sure, makes sense I guess

Jun 23 2020, 3:21 AM · arm64
val_packett.cool updated the diff for D25179: acpi_iort: fix mapping end calculation.
Jun 23 2020, 3:21 AM · arm64
val_packett.cool requested review of D25179: acpi_iort: fix mapping end calculation.
Jun 23 2020, 3:21 AM · arm64
val_packett.cool requested review of D24986: kern/subr_intr: fix build with DEBUG on arm64/aarch64.
Jun 23 2020, 3:20 AM · arm64

Jun 13 2020

val_packett.cool added reviewers for D25260: ichsmb_pci: convert to pci_device_table / add PCI_PNP_INFO: Contributor Reviews (src), mav, gavin.
Jun 13 2020, 5:27 PM
val_packett.cool requested review of D25260: ichsmb_pci: convert to pci_device_table / add PCI_PNP_INFO.
Jun 13 2020, 5:24 PM

Jun 11 2020

val_packett.cool accepted D25233: vkquake: Fix build when having no X11 deps.
Jun 11 2020, 2:14 PM