Only one MIPS-specific driver implements support for one of the
asymmetric operations. There are no in-kernel users besides
/dev/crypto. The only known user of the /dev/crypto interface was the
engine in OpenSSL releases before 1.1.0. 1.1.0 includes a rewritten
engine that does not use the asymmetric operations due to lack of
documentation.
Details
Details
- Reviewers
markj cem jmg - Group Reviewers
manpages - Commits
- rS366844: Mark asymmetric cryptography via OCF deprecated for 14.0.
- a little test program that invoked these ioctls triggered warnings
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| sys/opencrypto/cryptodev.c | ||
|---|---|---|
| 428 ↗ | (On Diff #78290) | As a matter of style I think it's nice to put static locals at the beginning of the declaration list. |
Comment Actions
Greg has the right spelling
| sys/opencrypto/cryptodev.c | ||
|---|---|---|
| 349 ↗ | (On Diff #78290) | I'm not sure multiple warnings, repeated every minute are helpful. I recently suffered from a long-standing nag log from ICMP that timed out after a minute, and it's 55% of my /var/log/messages with 0 value. I'd just warn maybe once? |
| 428 ↗ | (On Diff #78290) | +1 I even leave a blank line to separate them from other locals. |
| sys/opencrypto/cryptodev.c | ||
|---|---|---|
| 349 ↗ | (On Diff #78290) | This is the same logic we use for the deprecated symmetric crypto in stable/{11,12} now for both cryptodev and IPsec. People can always adjust the sysctl to tune the warning interval if necessary. (In fact, when this is MFC'd, it will be reusing the existing warninterval already in those branches that was removed in HEAD when I purged the deprecated symmetric crypto algorithms.) |
| 428 ↗ | (On Diff #78290) | We don't generally do the blank line with static locals (and I think the original location was just to match what was done previously for the symmetric warnings), but I'm happy to move it up. |