Paths

Table of Contentst

Differential D25629

Loader: explain currdev syntax
ClosedPublic
Actions

Authored by allanjude on Jul 11 2020, 7:52 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Sep 5, 12:28 AM

	Unknown Object (File)
	Fri, Sep 4, 7:54 PM

	Unknown Object (File)
	Fri, Sep 4, 2:29 AM

	Unknown Object (File)
	Thu, Sep 3, 4:22 AM

	Unknown Object (File)
	Wed, Sep 2, 10:11 PM

	Unknown Object (File)
	Wed, Sep 2, 10:41 AM

	Unknown Object (File)
	Wed, Sep 2, 8:23 AM

	Unknown Object (File)
	Wed, Sep 2, 2:46 AM

Subscribers

val_packett.cool

Details

Reviewers

kevans
tsoome
imp

Group Reviewers

Commits

rS363139: Loader: explain the syntax of currdev

Summary

The loader(8) man page doesn't explain how you correctly format currdev

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

allanjude created this revision.Jul 11 2020, 7:52 PM

Herald added a reviewer: manpages. · View Herald TranscriptJul 11 2020, 7:52 PM

allanjude requested review of this revision.Jul 11 2020, 7:52 PM

Harbormaster completed remote builds in B32260: Diff 74334.Jul 11 2020, 7:52 PM

tsoome accepted this revision.Jul 11 2020, 7:54 PM

This revision is now accepted and ready to land.Jul 11 2020, 7:54 PM

val_packett.cool added a subscriber: val_packett.cool.Jul 12 2020, 11:00 AM

val_packett.cool added inline comments.

stand/man/loader.8
486 ↗	(On Diff #74334)	huh, what's with the `:` at the end? I don't remember ever writing it

kevans accepted this revision.Jul 12 2020, 1:13 PM

kevans added inline comments.

stand/man/loader.8
486 ↗	(On Diff #74334)	I was under the impression it's to remove ambiguity, because we may literally glue currdev and a path together for,e.g., open(). Omitting it could cause hilarityto ensue, I believe.

allanjude added inline comments.Jul 13 2020, 2:07 AM

stand/man/loader.8
486 ↗	(On Diff #74334)	Yeah, because the path ends up being like: zfs:dataset:/boot/kernel/kernel etc The : at the end is very required. For ZFS, 'set currdev=zfs:dataset' will return an error, saying it is invalid without the trailing :

Closed by commit rS363139: Loader: explain the syntax of currdev (authored by allanjude). · Explain WhyJul 13 2020, 2:09 AM

This revision was automatically updated to reflect the committed changes.

allanjude added a commit: rS363139: Loader: explain the syntax of currdev.

Revision Contents
Changeset List

Path

Size

head/

stand/

man/

12 lines

Diff 74376

head/stand/man/loader.8

Loading...