Page MenuHomeFreeBSD

Only try to retrieve UUID from SMBIOS on x86 machines
Needs ReviewPublic

Authored by lwhsu on Nov 6 2020, 9:40 AM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 22 2023, 9:49 PM
Unknown Object (File)
Nov 15 2023, 4:47 AM
Unknown Object (File)
Aug 31 2023, 7:04 PM
Unknown Object (File)
Apr 8 2023, 10:28 AM
Unknown Object (File)
Mar 22 2023, 7:45 AM

Details

Reviewers
jhb
linimon
Summary

This is a new version of D9384, updated with jhb's suggestion and patch against
the new location of hostid file.

Proposed commit message:

Only try to retrieve UUID from SMBIOS on x86 machines

This prevents an useless warning message on non-x86 machines.

Also rename hostid_hardware() to hostid_smbios() to reflect what it actually
does.  In the future we may introduce more hostid_foo functions to obtain UUID
from firmware on other platforms.

Original work by: linimon

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 34664
Build 31733: arc lint + arc unit

Event Timeline

lwhsu requested review of this revision.Nov 6 2020, 9:40 AM

Server-class arm64 machines also have SMBIOS data present. Maybe just condition the actual warning print to amd64 | i386 but try it everywhere?