delete useless boot message on non-x86 machines
AcceptedPublic
Actions

Authored by linimon on Jan 30 2017, 3:29 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Jan 11, 8:01 AM

	Unknown Object (File)
	Sat, Jan 10, 4:41 PM

	Unknown Object (File)
	Sat, Jan 10, 5:15 AM

	Unknown Object (File)
	Fri, Jan 9, 6:48 PM

	Unknown Object (File)
	Mon, Dec 29, 6:31 PM

	Unknown Object (File)
	Nov 8 2025, 10:57 PM

	Unknown Object (File)
	Nov 6 2025, 11:37 PM

	Unknown Object (File)
	Nov 6 2025, 10:41 PM

View All 66 Files

Subscribers

jhb

ziaee

Details

Reviewers

jhb

Group Reviewers

Src Committers

Summary

/etc/rc.d/hostid attempts to read smbios data to generate a uuid, and complains if it is not found. It is annoying to see this message on e.g. powerpc64 boots.

The rework restricts the test for smbios data to x86 archs.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

linimon updated this revision to Diff 24564.Jan 30 2017, 3:29 PM

linimon retitled this revision from to delete useless boot message on non-x86 machines.

linimon updated this object.

linimon edited the test plan for this revision. (Show Details)

linimon added a reviewer: Src Committers.

linimon updated this revision to Diff 24565.Jan 30 2017, 3:32 PM

Tested on amd64 and powerpc64.

I like the idea. Perhaps rename hostid_hardware() to be hostid_smbios() as it is really about smbios and we might have methods to obtain an UUID from firmware on other platforms which will use different hostid_foo functions. _hardware is too generic a name for something that is really x86-specific.

This revision is now accepted and ready to land.Jan 30 2017, 6:12 PM

lwhsu mentioned this in D27113: Only try to retrieve UUID from SMBIOS on x86 machines.Nov 6 2020, 9:40 AM

Whatever happened to this?

Revision Contents
Changeset List

Path

Size

etc/

rc.d/

hostid

29 lines

Diff 24565

View Options

delete useless boot message on non-x86 machinesAcceptedPublicActions