Page MenuHomeFreeBSD

emax (maksim yevmenkin)
User

Projects

User Details

User Since
Mar 9 2015, 5:16 PM (222 w, 5 d)

Recent Activity

Jan 7 2019

emax accepted D3778: user friendly script as a frontend to bluetooth daemons.
Jan 7 2019, 4:33 PM

Apr 23 2018

emax accepted D13456: bthidd: Add evdev protocol support.

i think it looks good. i still question the whole idea of querying and putting remote device name in the configuration file, but, ultimately, this is not a hill I want to die on :)

Apr 23 2018, 4:03 PM

Jan 2 2018

emax added inline comments to D13456: bthidd: Add evdev protocol support.
Jan 2 2018, 3:55 PM
emax requested changes to D13456: bthidd: Add evdev protocol support.
Jan 2 2018, 3:36 AM

Dec 18 2017

emax requested changes to D13456: bthidd: Add evdev protocol support.

this looks great. my only comments are related to newly added "name" option / parameter. i can not seem to understand its purpose.

Dec 18 2017, 11:32 PM

Nov 1 2017

emax accepted D12831: bluetooth: Default to discoverable off.
Nov 1 2017, 5:30 PM
emax added a comment to D12831: bluetooth: Default to discoverable off.

depending on the device, the radio may be on the moment you apply power and internal firmware is booted.

I see. Further experimentation has confirmed this. The device seems to persist the "local name" configured by /etc/rc.d/bluetooth in some NVRAM because it survives reboots. That's unfortunate.

Nov 1 2017, 3:40 PM

Oct 31 2017

emax added a comment to D12831: bluetooth: Default to discoverable off.
In D12831#267334, @cem wrote:

Unfortunately, it isn't clear to me how we can actually prevent devd from loading ng_ubt. devd/usb.conf is autogenerated from the USB devids supported by modules.

Oct 31 2017, 11:55 PM
emax added inline comments to D12831: bluetooth: Default to discoverable off.
Oct 31 2017, 10:10 PM
emax added inline comments to D12831: bluetooth: Default to discoverable off.
Oct 31 2017, 6:27 PM
emax added inline comments to D12831: bluetooth: Default to discoverable off.
Oct 31 2017, 6:12 PM
emax added inline comments to D12831: bluetooth: Default to discoverable off.
Oct 31 2017, 5:46 PM

Oct 30 2017

emax added inline comments to D12831: bluetooth: Default to discoverable off.
Oct 30 2017, 11:26 PM
emax added inline comments to D12831: bluetooth: Default to discoverable off.
Oct 30 2017, 9:13 PM
emax added inline comments to D12831: bluetooth: Default to discoverable off.
Oct 30 2017, 9:11 PM
emax added inline comments to D12831: bluetooth: Default to discoverable off.
Oct 30 2017, 7:59 PM
emax added inline comments to D12831: bluetooth: Default to discoverable off.
Oct 30 2017, 5:30 PM
emax accepted D12672: bthidd: generate button release event after virtual T-axis button press.
Oct 30 2017, 5:28 PM

Sep 3 2017

emax accepted D12214: bthidd: Fix leds on multireport keyboards broken after r297217.
Sep 3 2017, 8:45 PM

Aug 1 2017

emax committed rS321890: fix sort order.
fix sort order
Aug 1 2017, 6:48 PM
emax committed rS321889: add myself.
add myself
Aug 1 2017, 6:46 PM

Apr 24 2017

emax accepted D10362: Make cached Bluetooth LE host advertise information visible from userland. .
Apr 24 2017, 7:33 PM

Apr 18 2017

emax requested changes to D10362: Make cached Bluetooth LE host advertise information visible from userland. .

please see my comments above. thanks!

Apr 18 2017, 8:56 PM

Apr 12 2017

emax requested changes to D10362: Make cached Bluetooth LE host advertise information visible from userland. .

can you please add boundary checks? thanks!

Apr 12 2017, 6:12 PM

Mar 5 2017

emax accepted D9878: Fix a memory leak in bluetooth/hccontrol.
Mar 5 2017, 7:35 PM

Apr 29 2016

emax accepted D3778: user friendly script as a frontend to bluetooth daemons.
Apr 29 2016, 5:06 PM

Apr 25 2016

emax accepted D3778: user friendly script as a frontend to bluetooth daemons.
Apr 25 2016, 11:26 PM

Mar 23 2016

emax committed rS297217: fix incorrect usage of hid_set_data() which causes crash.
fix incorrect usage of hid_set_data() which causes crash
Mar 23 2016, 10:07 PM

Dec 23 2015

emax committed rS292660: - grab ng_btsocket_l2cap_sockets_mtx lock in.
- grab ng_btsocket_l2cap_sockets_mtx lock in
Dec 23 2015, 4:32 PM

Nov 5 2015

emax committed rS290395: MFC r289637.
MFC r289637
Nov 5 2015, 4:08 PM

Oct 26 2015

emax accepted D3981: Bluetooth LE Security Manager Protocol Support.

thank you for your work!

Oct 26 2015, 5:19 PM

Oct 22 2015

emax requested changes to D3981: Bluetooth LE Security Manager Protocol Support.

please see comments. otherwise looks good on first read. thank you for your work!

Oct 22 2015, 5:43 PM

Oct 20 2015

emax committed rS289637: check boundaries while parsing SDP responses.
check boundaries while parsing SDP responses
Oct 20 2015, 6:01 PM

Oct 8 2015

emax accepted D3778: user friendly script as a frontend to bluetooth daemons.

looks believable

Oct 8 2015, 4:56 PM

Sep 27 2015

emax accepted D3702: Add support for vendor_id, product_id and version in bthidd. Adds support for Apple's magic mouse.
Sep 27 2015, 1:20 PM

Sep 24 2015

emax accepted D3702: Add support for vendor_id, product_id and version in bthidd. Adds support for Apple's magic mouse.
Sep 24 2015, 8:22 PM

Sep 22 2015

emax added a comment to D3702: Add support for vendor_id, product_id and version in bthidd. Adds support for Apple's magic mouse.

i think it looks fine. i, personally, would try to avoid using "odd" c syntax, i.e. comma and prefix in/decrement where there is no good reason for it. i would also sprinkle some comments explaining where "magic" numbers came from. of course author of the original code should get the credit too. otherwise it looks good. thank you for your work.

Sep 22 2015, 11:37 PM

Sep 11 2015

emax accepted D3635: Improve outlier latency by implementing batch size for bioq_disksort.
Sep 11 2015, 6:21 PM

May 15 2015

emax added a comment to D2556: Add a new 'exit timeout' option to watchdogd, used to specify the timeout to leave in effect when the program exits..

sorry, this

May 15 2015, 8:14 PM
emax added a comment to D2556: Add a new 'exit timeout' option to watchdogd, used to specify the timeout to leave in effect when the program exits..

just curious why watchdogd_sig_stop rc.conf knob is not working for you.

May 15 2015, 7:19 PM

Apr 5 2015

emax accepted D2230: bthidd: Remove unused macros from hid.c..

looks fine

Apr 5 2015, 11:42 PM
emax accepted D2021: Bluetooth 4.0 Support.

i'm accepting this assuming that possible build breakage related to L2CAP_SOCKET_CHECKED is going to verified. thank you for your work!

Apr 5 2015, 6:46 PM
emax added a comment to D2021: Bluetooth 4.0 Support.

couple of minor nits. please see inline. my main concern is to make sure #warning on sockaddr_l2cap is not going to break the build. please assume that L2CAP_SOCKET_CHECKED is likely to not be set. otherwise looks fine.

Apr 5 2015, 6:45 PM
emax accepted D2229: bthidd: Consider usage ranges when dealing with array inputs..
Apr 5 2015, 6:34 PM
emax added a comment to D2229: bthidd: Consider usage ranges when dealing with array inputs..

i don't think its worth worrying about. HID_USAGE is basically

Apr 5 2015, 6:10 PM
emax added a comment to D2229: bthidd: Consider usage ranges when dealing with array inputs..

looks fine to me.

Apr 5 2015, 6:05 PM
emax added inline comments to D2229: bthidd: Consider usage ranges when dealing with array inputs..
Apr 5 2015, 5:59 PM
emax added a comment to D2229: bthidd: Consider usage ranges when dealing with array inputs..

please see minor inline comment. thank you for your work!

Apr 5 2015, 5:49 PM

Mar 25 2015

emax added a comment to D2021: Bluetooth 4.0 Support.

it looks mostly good to me. a few minor nit picks, and, two somewhat bigger issues

Mar 25 2015, 3:54 PM

Mar 17 2015

emax added inline comments to D2021: Bluetooth 4.0 Support.
Mar 17 2015, 5:28 PM

Mar 11 2015

emax added a comment to D2021: Bluetooth 4.0 Support.

more inline comments

Mar 11 2015, 6:49 PM

Mar 9 2015

emax added inline comments to D2021: Bluetooth 4.0 Support.
Mar 9 2015, 7:41 PM