Page MenuHomeFreeBSD
Differential D21779

Fix Bluetooth LE related information parsing.
ClosedPublic
Actions

Authored by takawata on Sep 24 2019, 2:14 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mar 8 2024, 3:37 PM
Unknown Object (File)
Mar 8 2024, 3:37 PM
Unknown Object (File)
Mar 8 2024, 3:37 PM
Unknown Object (File)
Mar 8 2024, 3:25 PM
Unknown Object (File)
Feb 20 2024, 1:24 PM
Unknown Object (File)
Jan 22 2024, 2:10 AM
Unknown Object (File)
Dec 20 2023, 1:34 AM
Unknown Object (File)
Oct 20 2023, 12:31 PM
View All 19 Files
Subscribers
imp

Details

Reviewers
emax
Commits
rS360360: Fix advertise packet parsing.
Summary

Current version of hccontrol do not parse scan buffer correctly and only show local supported feature in a magic number.

This patch will fix this.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

takawata created this revision.Sep 24 2019, 2:14 PM
Harbormaster completed remote builds in B26671: Diff 62503.Sep 24 2019, 2:14 PM
emax added inline comments.Sep 24 2019, 3:54 PM
usr.sbin/bluetooth/hccontrol/node.c
250 ↗(On Diff #62503)

here and below. are there any concerns about buffer overrun? do you think the code should check length of data before trying to access it?

This revision was not accepted when it landed; it landed in state Needs Review.Apr 27 2020, 2:49 AM
Closed by commit rS360360: Fix advertise packet parsing. (authored by takawata). · Explain Why
This revision was automatically updated to reflect the committed changes.
takawata added a commit: rS360360: Fix advertise packet parsing..
Herald added a subscriber: imp. · View Herald TranscriptApr 27 2020, 2:49 AM

Revision Contents
Changeset List

PathSize
head/
usr.sbin/
bluetooth/
hccontrol/
35 lines

Diff 71030

View Options

head/usr.sbin/bluetooth/hccontrol/node.c

Loading...