Page MenuHomeFreeBSD

Fix a memory leak in bluetooth/hccontrol
ClosedPublic

Authored by trix_juniper.net on Mar 3 2017, 5:34 PM.

Details

Summary

hccontrol.c socket_open
When the input parameter node is NULL, memory is allocated to it.
To later free the memory, introduce a new variable lnode to track when this happens.

Test Plan

Run clang's static analyzer, scan-build, to find the problem and then later to show it has been resolved

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

trix_juniper.net retitled this revision from to Fix a memory leak in bluetooth/hccontrol.
trix_juniper.net updated this object.
trix_juniper.net edited the test plan for this revision. (Show Details)
trix_juniper.net added reviewers: stevek, takawata.
trix_juniper.net set the repository for this revision to rS FreeBSD src repository.
emax accepted this revision.Mar 5 2017, 7:35 PM
emax edited edge metadata.
This revision is now accepted and ready to land.Mar 5 2017, 7:35 PM
This revision was automatically updated to reflect the committed changes.