Fix a memory leak in bluetooth/hccontrol
ClosedPublic
Actions

Authored by trix_juniper.net on Mar 3 2017, 5:34 PM.

Details

Reviewers

stevek
emax
takawata

Commits

rS319639: When the input parameter node is NULL, memory is allocated to it.

Summary

hccontrol.c socket_open
When the input parameter node is NULL, memory is allocated to it.
To later free the memory, introduce a new variable lnode to track when this happens.

Test Plan

Run clang's static analyzer, scan-build, to find the problem and then later to show it has been resolved

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

trix_juniper.net updated this revision to Diff 25938.Mar 3 2017, 5:34 PM

trix_juniper.net retitled this revision from to Fix a memory leak in bluetooth/hccontrol.

trix_juniper.net updated this object.

trix_juniper.net edited the test plan for this revision. (Show Details)

trix_juniper.net added reviewers: stevek, takawata.

trix_juniper.net set the repository for this revision to rS FreeBSD src repository - subversion.

Herald added a subscriber: imp. · View Herald TranscriptMar 3 2017, 5:34 PM

takawata added a reviewer: emax.Mar 5 2017, 6:31 PM

emax accepted this revision.Mar 5 2017, 7:35 PM

emax edited edge metadata.

This revision is now accepted and ready to land.Mar 5 2017, 7:35 PM

Closed by commit rS319639: When the input parameter node is NULL, memory is allocated to it. (authored by stevek). · Explain WhyJun 6 2017, 10:18 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

usr.sbin/

bluetooth/

hccontrol/

hccontrol.c

4 lines

Diff 29287

View Options

head/usr.sbin/bluetooth/hccontrol/hccontrol.c

Fix a memory leak in bluetooth/hccontrolClosedPublicActions