LinuxKPI: support thread IDs in linux_task_exiting
ClosedPublic
Actions

Authored by val_packett.cool on Jun 29 2020, 9:19 PM.

Details

Reviewers

Commits

rS363153: MFC r362829:
rS363152: MFC r362829:
rS362829: The "pid" field in the LinuxKPI task struct is typically set to the thread ID

Summary

This fixes the display-server-hangs-forever-when-quitting problem in amdgpu: https://github.com/FreeBSDDesktop/kms-drm/issues/245

Basically this code was waiting for the process to get the exiting flag, but the function would get thread IDs, not proc IDs, so the condition would never arrive.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

val_packett.cool created this revision.Jun 29 2020, 9:19 PM

Herald added subscribers: emaste, imp. · View Herald TranscriptJun 29 2020, 9:19 PM

val_packett.cool requested review of this revision.Jun 29 2020, 9:19 PM

emaste added a subscriber: manu.Jun 29 2020, 9:30 PM

Change looks good! Do you need help submitting?

This revision is now accepted and ready to land.Jun 30 2020, 7:24 AM

In D25509#563827, @hselasky wrote:

Change looks good! Do you need help submitting?

yeah please commit

Closed by commit rS362829: The "pid" field in the LinuxKPI task struct is typically set to the thread ID (authored by • hselasky). · Explain WhyJul 1 2020, 8:24 AM

This revision was automatically updated to reflect the committed changes.

• hselasky added a commit: rS362829: The "pid" field in the LinuxKPI task struct is typically set to the thread ID.

• hselasky added a commit: rS363152: MFC r362829:.Jul 13 2020, 3:37 PM

• hselasky added a commit: rS363153: MFC r362829:.

Revision Contents
Changeset List

Path

Size

head/

sys/

compat/

linuxkpi/

common/

src/

linux_current.c

12 lines

Diff 73951

View Options

head/sys/compat/linuxkpi/common/src/linux_current.c

LinuxKPI: support thread IDs in linux_task_exitingClosedPublicActions