@kp here you go (lint error seems to be a false positive)

post merge clesanup

Add unit test

I haven't tested the changes myself, but this looks sound to me.

@markj @jrm I just committed be146a923dbda66f50c6b04b406da790837f6287 (cgit link) which addresses the issue in a more generic fashion (since we had these kinds of errors pop up over and over again). Even though I tested this locally and it seems to work as expected, it would be great if you could verify this at your end as well.

@markj Thanks, I'll look into it

@adrian @emaste @imp Thanks for reviewing

@jrm Thanks for providing a patch.

As I'm not sure who would be best suited for reviewing this change, I just added two overqualified people to the review.

@jhb @dchagin I'm currently porting https://crates.io/crates/cpu-affinity to FreeBSD (right now its FreeBSD support consists of noops) and I stumbled over something that might be by design:

In D36825#836513, @des wrote:

This is @grembo's code.

In D36457#828154, @imp wrote:

In D36457#828129, @grembo wrote:

So definitely nothing that's easy to reproduce it seems.

OK. That's both good and bad. Good that not everybody will hit it, bad that some will and we don't know who / how :(. If you manage to find a way to reproduce it, please let me know.

In D36457#827888, @imp wrote:

NOTE: When setting up the partition, I used the instructions from https://wiki.freebsd.org/UEFI which recommend newfs_msdos -F 32 -c 1. When simply using newfs_msdos /dev/..., the change in loader.env actually did the trick (and I could also list files on the resulting FAT16 partition).

Yea, usually one should only do -F 32 for partitions that are at least 1.25 * minimum size. Any smaller and there's too many buggy UEFI implementations that have heartburn...
These days with 4k sectors, the minimum is 4k x 65527 = 268MB, which means anything smaller than about 300-350MB will be more portable to more UEFI implementations as FAT16. Some guides go so far as to suggest doing FAT16 for < 500MB. However, it's hard to be categorical... We've run into at least one UEFI BIOS that only did FAT32 and the spec seems to suggest that only FAT32 is required. So your milage may vary, though there's a possibility there might be one or more bugs in stand/libsa/dosfs.c (which is what ls would use inside of loader.efi, for example). If you have a reproducible formula, I'll chase that down.

Straightforward and balanced.

@wulf Thanks for reviewing

• Make strlen calculation behave like on Linux (count trailing NUL)

Minor style change