Page MenuHomeFreeBSD
Differential D36482

stand: Unbreak FAT32 in loader
ClosedPublic
Actions

Authored by grembo on Sep 7 2022, 5:23 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, May 4, 4:20 AM
Unknown Object (File)
Dec 23 2023, 2:08 AM
Unknown Object (File)
Dec 12 2023, 4:06 PM
Unknown Object (File)
Dec 8 2023, 4:31 PM
Unknown Object (File)
Dec 8 2023, 4:18 PM
Unknown Object (File)
Sep 19 2023, 12:03 AM
Unknown Object (File)
Sep 18 2023, 11:57 PM
Unknown Object (File)
Sep 18 2023, 11:56 PM
View All 20 Files
Subscribers
dab
tsoome

Details

Reviewers
imp
manu
Commits
rG6d162b90b54b: stand: Unbreak FAT32 in loader
rG0eb736c0f673: stand: Unbreak FAT32 in loader
Summary

This corrects an issue introduced in b4cb3fe0e39a3, where a freshly
allocated DOS_FS structure would not be initialized properly before
use in dos_open.

In case of FAT32 file systems, this would leave fs->dirents
uninitialized and - depending on its content and due to checks in
parsebs - prevent mounting the file system successfully.

This particularily impacted the EFI loader, as it was sometimes not
able to read files from a FAT32-formatted EFI partition, including
LoaderEnv (/efi/freebsd/loader.env).

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

grembo created this revision.Sep 7 2022, 5:23 PM
Herald added a reviewer: manu. · View Herald TranscriptSep 7 2022, 5:23 PM
Herald added a subscriber: dab. · View Herald Transcript
grembo requested review of this revision.Sep 7 2022, 5:23 PM
Harbormaster completed remote builds in B47283: Diff 110313.Sep 7 2022, 5:23 PM
grembo mentioned this in D36457: stand: Parse all arguments passed by UEFI.Sep 7 2022, 5:27 PM
grembo edited the summary of this revision. (Show Details)Sep 7 2022, 5:33 PM
grembo added a subscriber: tsoome.Sep 7 2022, 5:36 PM
grembo added inline comments.
stand/libsa/dosfs.c
605

FAT32 enters this block (so fs->dirents isn't initialized).

619

And - depending on circumstances - this check will fail.

imp accepted this revision.Sep 7 2022, 11:30 PM

Cool! Thanks for tracking this all the way down...

This revision is now accepted and ready to land.Sep 7 2022, 11:30 PM
Closed by commit rG0eb736c0f673: stand: Unbreak FAT32 in loader (authored by grembo). · Explain WhySep 8 2022, 12:19 AM
This revision was automatically updated to reflect the committed changes.
grembo added a commit: rG0eb736c0f673: stand: Unbreak FAT32 in loader.
grembo added a commit: rG6d162b90b54b: stand: Unbreak FAT32 in loader.Oct 5 2022, 11:49 AM

Revision Contents
Changeset List

PathSize
stand/
libsa/
2 lines

Diff 110337

View Options

stand/libsa/dosfs.c

Loading...