Page MenuHomeFreeBSD

hidraw: Return string lengths for certain ioctls
ClosedPublic

Authored by grembo on May 17 2022, 9:43 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 30, 11:52 AM
Unknown Object (File)
Fri, Mar 21, 7:38 PM
Unknown Object (File)
Mar 3 2025, 10:08 AM
Unknown Object (File)
Feb 24 2025, 2:02 PM
Unknown Object (File)
Feb 23 2025, 11:40 PM
Unknown Object (File)
Feb 20 2025, 2:19 AM
Unknown Object (File)
Jan 24 2025, 7:40 AM
Unknown Object (File)
Jan 24 2025, 6:46 AM
Subscribers

Details

Summary

The hidraw(4) driver provides a set of Linux compatible ioctls. Three
of these return the length of the copied string on Linux, but they
always return 0 on FreeBSD:

  • HIDIOCGRAWPHYS
  • HIDIOCGRAWNAME
  • HIDIOCGRAWUNIQ

I noticed this while implementing hidraw(4) support for FreeBSD in
python-fido2[0], so there is some real-world software relying on
this return value (I would assume that this isn't the only one).

This patch aims to fix this by returning the length of the copied
string (including the trailing NUL character) in the affected ioctls.

[0]
https://github.com/Yubico/python-fido2/pull/139
https://github.com/Yubico/python-fido2/blob/master/fido2/hid/linux.py#L63-L74

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

grembo edited the summary of this revision. (Show Details)
  • Make strlen calculation behave like on Linux (count trailing NUL)
This revision is now accepted and ready to land.May 17 2022, 9:29 PM