Use iflib_if_init_locked() during media change instead of iflib_init_locked().
ClosedPublic
Actions

Authored by allanjude on Feb 14 2021, 6:46 PM.

Details

Reviewers

mmacy
markj
shurd
stevek
vmaffione
pkelsey

Group Reviewers

iflib

Commits

rG922cf8ac43ad: Use iflib_if_init_locked() during media change instead of iflib_init_locked().

Summary

iflib_init_locked() assumes that iflib_stop() has been called, however,
it is not called for media changes.
iflib_if_init_locked() calls stop then init, so fixes the problem.

PR: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=253473
MFC after: 3 days
Sponsored by: Juniper Networks, Inc., Klara, Inc.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 36997
Build 33886: arc lint + arc unit

Event Timeline

allanjude created this revision.Feb 14 2021, 6:46 PM

Herald added a reviewer: iflib. · View Herald TranscriptFeb 14 2021, 6:46 PM

Herald added subscribers: melifaro, ae, imp. · View Herald Transcript

allanjude requested review of this revision.Feb 14 2021, 6:46 PM

Harbormaster completed remote builds in B36997: Diff 83884.Feb 14 2021, 6:47 PM

allanjude edited the summary of this revision. (Show Details)Feb 14 2021, 6:50 PM

Seems right. Other callers of iflib_init_locked() look ok.

This revision was not accepted when it landed; it landed in state Needs Review.Feb 16 2021, 7:02 PM

Closed by commit rG922cf8ac43ad: Use iflib_if_init_locked() during media change instead of iflib_init_locked(). (authored by allanjude). · Explain Why

This revision was automatically updated to reflect the committed changes.

allanjude added a commit: rG922cf8ac43ad: Use iflib_if_init_locked() during media change instead of iflib_init_locked()..

Revision Contents
Changeset List

Path

Size

sys/

net/

iflib.c

2 lines

Diff 83884

View Options

Use iflib_if_init_locked() during media change instead of iflib_init_locked().ClosedPublicActions