Page MenuHomeFreeBSD
Differential D32389

iflib: Create led(4) devices
ClosedPublic
Actions

Authored by kbowling on Oct 9 2021, 3:14 AM.
Tags
None
Referenced Files
F170677122: D32389.id96528.diff
Sat, Sep 5, 11:40 PM
Unknown Object (File)
Fri, Sep 4, 5:56 PM
Unknown Object (File)
Wed, Sep 2, 6:57 PM
Unknown Object (File)
Fri, Aug 28, 4:51 AM
Unknown Object (File)
Sat, Aug 22, 12:48 PM
Unknown Object (File)
Wed, Aug 19, 2:15 PM
Unknown Object (File)
Tue, Aug 18, 8:42 PM
Unknown Object (File)
Tue, Aug 18, 8:24 PM
View All Files
Subscribers
ae
glebius
imp
jlduran
melifaro

Details

Reviewers
markj
shurd
Group Reviewers
Intel Networking
iflib
Commits
rGba7e8e8dcb31: iflib: Create led(4) devices
rGdbf07219675e: iflib: Create led(4) devices
rG6591a7f69192: iflib: Create led(4) devices
Summary

If the driver defines an led_func, have the framework create them during attach.

PR: 246885
Reported by: Jose Luis Duran <jlduran@gmail.com>

Test Plan

Tested on I350:
echo "f3" > /dev/led/igb0
echo "0" > /dev/led/igb0

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kbowling created this revision.Oct 9 2021, 3:14 AM
Herald added a reviewer: shurd. · View Herald TranscriptOct 9 2021, 3:14 AM
Herald added a reviewer: iflib. · View Herald Transcript
Herald added subscribers: melifaro, ae, imp. · View Herald Transcript
kbowling requested review of this revision.Oct 9 2021, 3:14 AM
kbowling added a parent revision: D32388: led: Eliminate sleepable mutex.
jlduran added a subscriber: jlduran.Oct 9 2021, 4:28 AM
kbowling added a comment.EditedOct 9 2021, 5:30 AM

Jose submitted a variant where the driver (e1000 in this case) calls the iflib_led_create() function in its post attach. I am open to either approach if anyone has any thoughts one way or the other.

jlduran added a comment.EditedOct 9 2021, 6:56 AM

I prefer this approach.

Regardless of which patch you choose, on my home router (2 i211-based NICs), identifying /dev/led/igb0 works, but /dev/led/igb1 do not.

Nevertheless, the LED devices are created as well. Thank you!

markj accepted this revision.Oct 9 2021, 4:21 PM

Seems ok. This kind of reflection looks a bit hacky but I see it used elsewhere. Probably we should have some kobj.h helper to do it.

sys/net/iflib.c
5440

And on the next line too.

5444
This revision was not accepted when it landed; it landed in state Needs Review.Wed, Aug 12, 2:11 AM
Closed by commit rG6591a7f69192: iflib: Create led(4) devices (authored by Kevin Bowling <kbowling@FreeBSD.org>). · Explain Why
This revision was automatically updated to reflect the committed changes.
Kevin Bowling <kbowling@FreeBSD.org> added a commit: rG6591a7f69192: iflib: Create led(4) devices.
Herald added a subscriber: glebius. · View Herald TranscriptWed, Aug 12, 2:11 AM
Kevin Bowling <kbowling@FreeBSD.org> added a commit: rGdbf07219675e: iflib: Create led(4) devices.Wed, Aug 26, 12:25 AM
Kevin Bowling <kbowling@FreeBSD.org> added a commit: rGba7e8e8dcb31: iflib: Create led(4) devices.

Revision Contents
Changeset List

PathSize
sys/
net/
7 lines

Diff 183905

View Options

sys/net/iflib.c

Loading...