Page MenuHomeFreeBSD
Differential D52307

libsamplerate: Define as PRIVATELIB
ClosedPublic
Actions

Authored by christos on Aug 31 2025, 4:30 PM.
Tags
None
Referenced Files
F164309284: D52307.diff
Thu, Jul 30, 3:37 PM
F164294369: D52307.id162062.diff
Thu, Jul 30, 11:59 AM
Unknown Object (File)
Mon, Jul 27, 8:15 PM
Unknown Object (File)
Sat, Jul 25, 3:16 PM
Unknown Object (File)
Tue, Jul 21, 2:05 PM
Unknown Object (File)
Sat, Jul 18, 1:34 AM
Unknown Object (File)
Sat, Jul 18, 12:03 AM
Unknown Object (File)
Fri, Jul 17, 11:35 AM
View All 77 Files
Subscribers
bdrewery
emaste
imp
ivy

Details

Reviewers
kevans
fuz
Commits
rG44114a581fba: libsamplerate: Define as PRIVATELIB
rGdafd960a3d65: libsamplerate: Define as PRIVATELIB
Summary

Fixes the following warnings:

ld: error: relocation R_X86_64_32S cannot be used against local symbol; recompile with -fPIC

defined in /usr/obj/usr/src/amd64.amd64/lib/libsamplerate/libsamplerate.a(samplerate.o)
referenced by samplerate.c:498 (/usr/src/contrib/libsamplerate/samplerate.c:498)

samplerate.o:(src_new) in archive /usr/obj/usr/src/amd64.amd64/lib/libsamplerate/libsamplerate.a

Related discussion: https://reviews.freebsd.org/D52306

Sponsored by: The FreeBSD Foundation

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 66716
Build 63599: arc lint + arc unit

Event Timeline

christos created this revision.Aug 31 2025, 4:30 PM
Herald added subscribers: emaste, imp, bdrewery. · View Herald TranscriptAug 31 2025, 4:30 PM
christos requested review of this revision.Aug 31 2025, 4:30 PM
Harbormaster completed remote builds in B66715: Diff 161291.Aug 31 2025, 4:30 PM
christos mentioned this in D52306: libsamplerate: Compile with -fPIC.Aug 31 2025, 4:32 PM
fuz requested changes to this revision.Aug 31 2025, 4:42 PM

Needs an entry in etc/mtree/BSD.usr.dist for include/private/samplerate (thanks, @kevans)

===> lib/libsamplerate (includes)
install -U  -C -o root -g wheel -m 444  /usr/home/fuz/src/repo/freebsd-src/contrib/libsamplerate/samplerate.h /usr/obj/usr/home/fuz/src/repo/freebsd-src/amd64.amd64/tmp/usr/include/private/samplerate/
install: /usr/obj/usr/home/fuz/src/repo/freebsd-src/amd64.amd64/tmp/usr/include/private/samplerate: No such file or directory
*** Error code 71

Stop.
make[4]: stopped making "includes" in /usr/home/fuz/src/repo/freebsd-src/lib/libsamplerate
This revision now requires changes to proceed.Aug 31 2025, 4:42 PM
christos updated this revision to Diff 161292.Aug 31 2025, 4:44 PM

Add to BSD.usr.dist

Harbormaster completed remote builds in B66716: Diff 161292.Aug 31 2025, 4:44 PM
christos added a child revision: D52308: virtual_oss: Port to base.Aug 31 2025, 4:53 PM
fuz accepted this revision.Aug 31 2025, 6:06 PM

Seems to build fine.

This revision is now accepted and ready to land.Aug 31 2025, 6:06 PM
Closed by commit rGdafd960a3d65: libsamplerate: Define as PRIVATELIB (authored by christos). · Explain WhySep 15 2025, 1:15 PM
This revision was automatically updated to reflect the committed changes.
christos added a commit: rGdafd960a3d65: libsamplerate: Define as PRIVATELIB.
christos added a commit: rG44114a581fba: libsamplerate: Define as PRIVATELIB.Oct 8 2025, 12:55 PM
Herald added a subscriber: ivy. · View Herald TranscriptOct 8 2025, 12:55 PM

Revision Contents
Changeset List

PathSize
etc/
mtree/
2 lines
lib/
libsamplerate/
2 lines
share/
mk/
2 lines

Diff 161292

View Options

etc/mtree/BSD.usr.dist

Loading...
View Options

lib/libsamplerate/Makefile

Loading...
View Options

share/mk/src.libnames.mk

Loading...