libsamplerate: Compile with -fPIC
AbandonedPublic
Actions

Authored by christos on Aug 31 2025, 4:05 PM.

Details

Reviewers

fuz
kevans

Summary

Fixes the following warnings:

ld: error: relocation R_X86_64_32S cannot be used against local symbol; recompile with -fPIC

defined in /usr/obj/usr/src/amd64.amd64/lib/libsamplerate/libsamplerate.a(samplerate.o)
referenced by samplerate.c:498 (/usr/src/contrib/libsamplerate/samplerate.c:498)
samplerate.o:(src_new) in archive /usr/obj/usr/src/amd64.amd64/lib/libsamplerate/libsamplerate.a

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 66714
Build 63597: arc lint + arc unit

Event Timeline

christos created this revision.Aug 31 2025, 4:05 PM

Herald added a subscriber: imp. · View Herald TranscriptAug 31 2025, 4:05 PM

christos requested review of this revision.Aug 31 2025, 4:05 PM

Harbormaster completed remote builds in B66714: Diff 161290.Aug 31 2025, 4:05 PM

The problem here is that we made libsamplerate an internal library, which means it's a static library. However, various virtual_oss plugins (which are shared objects) link libsamplerate, so an attempt is made to link a static library into a shared object.

The correct fix is probably to turn this from an internal library into a private library, which means it's a shared object. It's also conceivable to just link it statically into the various plugins, but at 1.5 MB for the library, that's quite the wasted space.

christos mentioned this in D52307: libsamplerate: Define as PRIVATELIB.Aug 31 2025, 4:30 PM

D52307

christos mentioned this in rGdafd960a3d65: libsamplerate: Define as PRIVATELIB.Mon, Sep 15, 1:15 PM

christos mentioned this in rG44114a581fba: libsamplerate: Define as PRIVATELIB.Wed, Oct 8, 12:55 PM