Page MenuHomeFreeBSD

libsamplerate: Define as PRIVATELIB
ClosedPublic

Authored by christos on Aug 31 2025, 4:30 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Oct 10, 4:13 AM
Unknown Object (File)
Fri, Oct 10, 4:13 AM
Unknown Object (File)
Fri, Oct 10, 4:13 AM
Unknown Object (File)
Fri, Oct 10, 4:13 AM
Unknown Object (File)
Thu, Oct 9, 10:58 PM
Unknown Object (File)
Wed, Oct 8, 7:19 AM
Unknown Object (File)
Tue, Sep 30, 11:49 AM
Unknown Object (File)
Thu, Sep 25, 10:57 PM

Details

Summary

Fixes the following warnings:

ld: error: relocation R_X86_64_32S cannot be used against local symbol; recompile with -fPIC

defined in /usr/obj/usr/src/amd64.amd64/lib/libsamplerate/libsamplerate.a(samplerate.o)
referenced by samplerate.c:498 (/usr/src/contrib/libsamplerate/samplerate.c:498)

samplerate.o:(src_new) in archive /usr/obj/usr/src/amd64.amd64/lib/libsamplerate/libsamplerate.a

Related discussion: https://reviews.freebsd.org/D52306

Sponsored by: The FreeBSD Foundation

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

fuz requested changes to this revision.Aug 31 2025, 4:42 PM

Needs an entry in etc/mtree/BSD.usr.dist for include/private/samplerate (thanks, @kevans)

===> lib/libsamplerate (includes)
install -U  -C -o root -g wheel -m 444  /usr/home/fuz/src/repo/freebsd-src/contrib/libsamplerate/samplerate.h /usr/obj/usr/home/fuz/src/repo/freebsd-src/amd64.amd64/tmp/usr/include/private/samplerate/
install: /usr/obj/usr/home/fuz/src/repo/freebsd-src/amd64.amd64/tmp/usr/include/private/samplerate: No such file or directory
*** Error code 71

Stop.
make[4]: stopped making "includes" in /usr/home/fuz/src/repo/freebsd-src/lib/libsamplerate
This revision now requires changes to proceed.Aug 31 2025, 4:42 PM

Seems to build fine.

This revision is now accepted and ready to land.Aug 31 2025, 6:06 PM
This revision was automatically updated to reflect the committed changes.