Page MenuHomeFreeBSD
Differential D52142

[net80211] Quieten the logging from ieee80211_vht_get_vhtflags()
ClosedPublic
Actions

Authored by adrian on Mon, Aug 25, 12:52 AM.
Tags
Referenced Files
Unknown Object (File)
Mon, Sep 8, 5:46 PM
Unknown Object (File)
Sat, Sep 6, 5:01 PM
Unknown Object (File)
Tue, Aug 26, 1:48 AM
Unknown Object (File)
Tue, Aug 26, 1:47 AM
Unknown Object (File)
Tue, Aug 26, 12:33 AM
Unknown Object (File)
Mon, Aug 25, 7:05 AM
Unknown Object (File)
Mon, Aug 25, 6:39 AM
Unknown Object (File)
Mon, Aug 25, 5:33 AM
Subscribers
bz
glebius
imp
melifaro

Details

Reviewers
bz
Group Reviewers
wireless
Commits
rGd6616705231c: [net80211] Quieten the logging from ieee80211_vht_get_vhtflags()
Summary

The commit in Fixes: introduced logging the output bits from
ieee80211_vht_get_vhtflags(). This ends up causing quite a lot
of logging when net80211 is doing things like processing
received beacons.

So just remove the logging; if it's needed again then a developer
can add it back to that location, or just use dtrace to capture
the return value.

Fixes: 4bf049bfeefd9

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 66707
Build 63590: arc lint + arc unit

Event Timeline

adrian created this revision.Mon, Aug 25, 12:52 AM
Herald added subscribers: glebius, melifaro, imp. · View Herald TranscriptMon, Aug 25, 12:52 AM
adrian requested review of this revision.Mon, Aug 25, 12:52 AM
Harbormaster completed remote builds in B66495: Diff 160911.Mon, Aug 25, 12:52 AM
adrian added a parent revision: D50772: net80211: convert the rest of the native net80211 drivers to SEQNO_OFFLOAD.Mon, Aug 25, 12:53 AM
adrian added a reviewer: wireless.
adrian added a project: wireless.
bz requested changes to this revision.Mon, Aug 25, 5:47 AM
bz added a subscriber: bz.
bz added inline comments.
sys/net80211/ieee80211_ht.c
1936

On which (properly done) driver do you see (say) 10 beacons a second?

My net80211 wlanstats says I saw 35 beacons in 9 hours of uptime.
For iwx see email; beacon filtering is disabled (or not finished).

How much doe you see on rtwn or iwn?

I'd suggest to solve it this way:

if (0} IEEE80211_NOTE...

Disabling the logging if it really bothers you and you think this is an issue here.

This revision now requires changes to proceed.Mon, Aug 25, 5:47 AM
adrian added inline comments.Sun, Aug 31, 3:06 AM
sys/net80211/ieee80211_ht.c
1936

I'll disable it like this.

For rtwn, that processes all the beacons all the time (they're not ONLY handled in firmware):

adrian@francine:~ % wlanstats -i wlan0 | grep -i beacon
36113             rx beacon frames
1                 beacon miss events handled
adrian added a child revision: D52297: [net80211] add support for drivers to disable sending NULL data frames.Sun, Aug 31, 3:07 AM
adrian updated this revision to Diff 161283.Sun, Aug 31, 3:13 AM

request from bz

Harbormaster completed remote builds in B66707: Diff 161283.Sun, Aug 31, 3:14 AM
adrian marked an inline comment as done.Sun, Aug 31, 3:14 AM
adrian edited parent revisions, added: D50794: net80211: don't dereference a NULL HTINFO IE if it's presented; removed: D50772: net80211: convert the rest of the native net80211 drivers to SEQNO_OFFLOAD.
bz requested changes to this revision.Mon, Sep 1, 1:06 AM
bz added inline comments.
sys/net80211/ieee80211_ht.c
1937

Can you please reduce this to one line changed?

This revision now requires changes to proceed.Mon, Sep 1, 1:06 AM
adrian updated this revision to Diff 161686.Sun, Sep 7, 7:40 PM

comment from bz

adrian marked an inline comment as done.Sun, Sep 7, 7:41 PM

ok, reduced to one line diff, please re-review! thanks!

Harbormaster completed remote builds in B66875: Diff 161686.Sun, Sep 7, 7:41 PM
bz accepted this revision.Sun, Sep 7, 7:46 PM
This revision is now accepted and ready to land.Sun, Sep 7, 7:46 PM
Closed by commit rGd6616705231c: [net80211] Quieten the logging from ieee80211_vht_get_vhtflags() (authored by adrian). · Explain WhyMon, Sep 8, 12:13 AM
This revision was automatically updated to reflect the committed changes.
adrian added a commit: rGd6616705231c: [net80211] Quieten the logging from ieee80211_vht_get_vhtflags().

Revision Contents
Changeset List

PathSize
sys/
net80211/
6 lines

Diff 161283

View Options

sys/net80211/ieee80211_ht.c

Loading...