Page MenuHomeFreeBSD
Differential D51947

vfs: Introduce VN_ISDEV() macro
ClosedPublic
Actions

Authored by des on Aug 17 2025, 2:17 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jun 18, 10:08 PM
Unknown Object (File)
Sun, Jun 14, 2:27 PM
Unknown Object (File)
Mon, Jun 8, 2:55 PM
Unknown Object (File)
Wed, May 27, 11:16 PM
Unknown Object (File)
May 17 2026, 2:11 PM
Unknown Object (File)
May 17 2026, 1:32 PM
Unknown Object (File)
May 17 2026, 1:14 PM
Unknown Object (File)
May 17 2026, 8:59 AM
View All Files
Subscribers
asomers
imp
mckusick
olce

Details

Reviewers
kib
mckusick
Group Reviewers
Klara
Commits
rG567e6250c003: vfs: Introduce VN_ISDEV() macro
Summary

We frequently need to check if a vnode refers to either a character or
block special, so we might as well have a macro for it.

Sponsored by: Klara, Inc.
Sponsored by: NetApp, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 66303
Build 63186: arc lint + arc unit

Event Timeline

des created this revision.Aug 17 2025, 2:17 PM
Herald added subscribers: olce, asomers, imp. · View Herald TranscriptAug 17 2025, 2:17 PM
des requested review of this revision.Aug 17 2025, 2:17 PM
des added a parent revision: D51943: ufs: st_rdev is only meaningful for special nodes.Aug 17 2025, 2:18 PM
Harbormaster completed remote builds in B66300: Diff 160458.Aug 17 2025, 2:18 PM
des planned changes to this revision.Aug 17 2025, 2:19 PM

looks like I missed a few occurrences, brb

des updated this revision to Diff 160460.Aug 17 2025, 2:24 PM

a few more

Harbormaster completed remote builds in B66302: Diff 160460.Aug 17 2025, 2:24 PM
des updated this revision to Diff 160461.Aug 17 2025, 3:09 PM

unbreak nfs

Harbormaster completed remote builds in B66303: Diff 160461.Aug 17 2025, 3:09 PM
kib added inline comments.Aug 17 2025, 3:11 PM
sys/fs/nfsserver/nfs_nfsdport.c
1260 ↗(On Diff #160460)

I do not think this chunk could compile.

sys/sys/vnode.h
234

I suggest to add

#define VN_TYPE_ISDEV(typ) ((typ) == VCHR || (typ) == VBLK)

and then

define VN_ISDEV(_vp) VN_TYPE_ISDEV((_vp)->v_type)

This allows to convert several more cases to the VN_TYPE_ISDEV() macro.

des updated this revision to Diff 160468.Aug 17 2025, 3:53 PM

fix

Harbormaster completed remote builds in B66304: Diff 160468.Aug 17 2025, 3:53 PM
des added a child revision: D51955: ext2fs: Set st_rdev to NODEV when not a device.Aug 17 2025, 3:55 PM
des added a child revision: D51956: vfs: Assert that st_rdev is NODEV for non-devices.
kib accepted this revision.Aug 17 2025, 4:17 PM
This revision is now accepted and ready to land.Aug 17 2025, 4:17 PM
des updated this revision to Diff 160474.Aug 17 2025, 4:33 PM

as suggested

This revision now requires review to proceed.Aug 17 2025, 4:33 PM
Harbormaster completed remote builds in B66308: Diff 160474.Aug 17 2025, 4:33 PM
des updated this revision to Diff 160475.Aug 17 2025, 4:34 PM

as suggested

Harbormaster completed remote builds in B66309: Diff 160475.Aug 17 2025, 4:34 PM
des marked an inline comment as done.Aug 17 2025, 4:35 PM
kib accepted this revision.Aug 17 2025, 4:36 PM
This revision is now accepted and ready to land.Aug 17 2025, 4:36 PM
mckusick accepted this revision.Aug 17 2025, 5:41 PM
mckusick added a subscriber: mckusick.

I am always in favor of improvement to code clarity.

des closed this revision.Aug 18 2025, 3:22 PM
des added a commit: rG567e6250c003: vfs: Introduce VN_ISDEV() macro.

Revision Contents
Changeset List

PathSize
sys/
fs/
cd9660/
12 lines
ext2fs/
14 lines
fuse/
2 lines
nfsclient/
2 lines
p9fs/
2 lines
tarfs/
5 lines
tmpfs/
17 lines
kern/
2 lines
2 lines
sys/
3 lines
ufs/
ffs/
12 lines
ufs/
16 lines
vm/
3 lines

Diff 160461

View Options

sys/fs/cd9660/cd9660_vnops.c

Loading...
View Options

sys/fs/ext2fs/ext2_vnops.c

Loading...
View Options

sys/fs/fuse/fuse_vnops.c

Loading...
View Options

sys/fs/nfsclient/nfs_clvnops.c

Loading...
View Options

sys/fs/p9fs/p9fs_vnops.c

Loading...
View Options

sys/fs/tarfs/tarfs_vnops.c

Loading...
View Options

sys/fs/tmpfs/tmpfs_vnops.c

Loading...
View Options

sys/kern/vfs_bio.c

Loading...
View Options

sys/kern/vfs_syscalls.c

Loading...
View Options

sys/sys/vnode.h

Loading...
View Options

sys/ufs/ffs/ffs_vnops.c

Loading...
View Options

sys/ufs/ufs/ufs_vnops.c

Loading...
View Options

sys/vm/vnode_pager.c

Loading...