Page MenuHomeFreeBSD

ufs: st_rdev is only meaningful for special nodes
ClosedPublic

Authored by kib on Aug 17 2025, 1:05 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Oct 13, 11:42 PM
Unknown Object (File)
Mon, Oct 13, 11:42 PM
Unknown Object (File)
Mon, Oct 13, 11:42 PM
Unknown Object (File)
Mon, Oct 13, 10:14 AM
Unknown Object (File)
Sat, Sep 27, 1:24 AM
Unknown Object (File)
Sat, Sep 27, 12:03 AM
Unknown Object (File)
Fri, Sep 26, 11:20 PM
Unknown Object (File)
Fri, Sep 26, 11:43 AM
Subscribers

Details

Summary
Instead of leaking di_db[0] (for regular files this is the index of the
first block of the file), return NODEV when not a special node.

Reported by:    des

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kib requested review of this revision.Aug 17 2025, 1:05 PM

There are 46 instances of (foo->v_type == VBLK || foo->v_type == VCHR) or its negation in the tree, and this adds four. That's probably a sign that we should have a macro for it.

This revision is now accepted and ready to land.Aug 17 2025, 1:52 PM