ufs: st_rdev is only meaningful for special nodes
ClosedPublic
Actions

Authored by kib on Aug 17 2025, 1:05 PM.

Details

Reviewers

des
markj
mckusick

Commits

rG6fd60c4887cb: ufs: st_rdev is only meaningful for special nodes

Summary

Instead of leaking di_db[0] (for regular files this is the index of the
first block of the file), return NODEV when not a special node.

Reported by:    des

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kib created this revision.Aug 17 2025, 1:05 PM

Herald added a subscriber: imp. · View Herald TranscriptAug 17 2025, 1:05 PM

kib requested review of this revision.Aug 17 2025, 1:05 PM

kib mentioned this in D51944: ufs: Set st_rdev to 0 for non-devices.Aug 17 2025, 1:41 PM

There are 46 instances of (foo->v_type == VBLK || foo->v_type == VCHR) or its negation in the tree, and this adds four. That's probably a sign that we should have a macro for it.

This revision is now accepted and ready to land.Aug 17 2025, 1:52 PM

des added a child revision: D51947: vfs: Introduce VN_ISDEV() macro.Aug 17 2025, 2:18 PM

Closed by commit rG6fd60c4887cb: ufs: st_rdev is only meaningful for special nodes (authored by kib). · Explain WhyAug 17 2025, 4:13 PM

This revision was automatically updated to reflect the committed changes.

kib added a commit: rG6fd60c4887cb: ufs: st_rdev is only meaningful for special nodes.