Differential D51956

vfs: Assert that st_rdev is NODEV for non-devices
ClosedPublic
Actions

Authored by des on Aug 17 2025, 3:55 PM.

Tags

None

Referenced Files

	F162006050: D51956.id160471.diff
	Wed, Jul 8, 8:47 PM

	Unknown Object (File)
	Wed, Jul 8, 7:58 AM

	Unknown Object (File)
	Wed, Jul 8, 4:42 AM

	Unknown Object (File)
	Sun, Jul 5, 8:50 AM

	Unknown Object (File)
	Sat, Jun 27, 9:00 AM

	Unknown Object (File)
	Tue, Jun 23, 1:52 PM

	Unknown Object (File)
	May 29 2026, 7:44 AM

	Unknown Object (File)
	May 29 2026, 6:52 AM

View All 68 Files

Subscribers

imp

olce

Details

Reviewers

kib

Commits

rGf9ff1e48cc1b: vfs: Assert that st_rdev is NODEV for non-devices

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

des created this revision.Aug 17 2025, 3:55 PM

Herald added subscribers: olce, imp. · View Herald TranscriptAug 17 2025, 3:55 PM

des requested review of this revision.Aug 17 2025, 3:55 PM

Harbormaster completed remote builds in B66307: Diff 160471.Aug 17 2025, 3:55 PM

des added parent revisions: D51955: ext2fs: Set st_rdev to NODEV when not a device, D51954: zfs: Set st_rdev to NODEV, not 0, when not a device, D51947: vfs: Introduce VN_ISDEV() macro.Aug 17 2025, 3:56 PM

I am sure there would be several missed cases.

This revision is now accepted and ready to land.Aug 17 2025, 4:20 PM

Closed by commit rGf9ff1e48cc1b: vfs: Assert that st_rdev is NODEV for non-devices (authored by des). · Explain WhyAug 17 2025, 5:31 PM

This revision was automatically updated to reflect the committed changes.

des added a commit: rGf9ff1e48cc1b: vfs: Assert that st_rdev is NODEV for non-devices.

des added a reverting change: rG2bc115a6c287: Revert "vfs: Assert that st_rdev is NODEV for non-devices".Aug 17 2025, 11:56 PM

Revision Contents
Changeset List

Path

Size

sys/

kern/

vfs_syscalls.c

2 lines

Diff 160481

View Options

vfs: Assert that st_rdev is NODEV for non-devicesClosedPublicActions