Why do these targets exist? I see they exist in src/kerberos, but they seem quite sketchy so why bring them along.

All this and below is extraneous. I had copied this in to maintain a mental note. Te rest of this file has been removed.

Good catch. These were copied from kerberos5/Makefile when the project started a year ago. I had not intended on using them.

Thank you for catching this.

I should attribute this Makefile to the kerberos5 Makefile. The other makefiles in krb5/util and krb5/lib were inspired by libc and ncurses.

There is no reason to use classic make syntax.

AFACT this does nothing, we just have it in a number of legacy makefiles. I've posted D50704 to remove the other cases.

Surely none of this is needed

Yikes!

Is this the right date?

Shouldn't be necessary as bsd.prog.mk pulls it it. There are a whole bunch of these I've not commented on.

Why is this not in CLEANFILES?

Maybe to ignore for now, but this file seems to be pointless compat for ancient systems.

No opts are being used. There a a bunch of these.

style: line is quite long

I think this is the default value?

-I. is surprising. There don't seem to be any generated headers.

Forcing -fPIC seems surprising.

Feels like a WIP not something to commit

This will always rebuild. Shouldn't it depend on rc4.c instead? md5 etc don't do this.

Will always rebuild

A whole bunch of files have .SUFFIXES but no suffix rules. Not sure what's going on.

If these rules are used then there need to be CLEANFILES entries.

???

Won't the SUFFIX rules take care of this?

Duplicate

Could all these SUFFIX rules live in a Makefile.inc?

No rule?

duplicate

It feels like these should live in a shell script that uses a temp directory rather than churning in .OBJDIR

Should these be hardcoded paths?

Thanks. All instances have been standardized to new syntax.

Removed.

They've been removed and Makefiles simplified.

Yes, it needs this. Tested with others. Plus, the upstream tarball doesn't do much more either.

This is when I wrote it. The FF didn't get involved until a couple of months ago. I could update the date to more recent.

I missed that one.

Thank you for spotting this.

Removed.

Oops.

Typo, sofware, seems to be copy-pasted throughout.

Does "." get used as the current directory? I think it should use ${.CURDIR} instead so that it's easier to see what's happening when reading build logs.

We tend to use ${.TARGET} instead of $@ in system makefiles.

(These comments apply to several makefiles, not just this one.)

Yes. That argument is a directory. In this case current directory. I will make this change.