Details

Reviewers

Group Reviewers

iflib
Intel Networking

Commits

rG67c30c246d16: iflib: Add subinterface interrupt allocation function
rG59d1c385f681: iflib: Add subinterface interrupt allocation function
rGed34a6b6eab9: iflib: Add subinterface interrupt allocation function

Summary

The ice(4) driver will add the ability to create extra interfaces
that hang off of the base interface; to do that the driver requires
a method for the subinterface to request hardware interrupt resources
from the base interface. This functionality is planned to be upstreamed to the ice(4) driver soon.

Note: this is part of a stack of patches that also includes whitespace fixes as well as an extra helper function.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

erj created this revision.May 1 2023, 11:42 PM

erj held this revision as a draft.

Herald added a reviewer: shurd. · View Herald TranscriptMay 1 2023, 11:42 PM

Herald added a reviewer: iflib. · View Herald Transcript

Herald added subscribers: glebius, melifaro, ae, imp. · View Herald Transcript

Harbormaster completed remote builds in B51303: Diff 121370.May 1 2023, 11:42 PM

erj published this revision for review.May 1 2023, 11:43 PM

gallatin added a subscriber: gallatin.May 2 2023, 2:06 PM

gallatin added inline comments.

sys/net/iflib.c
2516	Can you explain the move from sctx to scctx here?
6863–6864	As I said on the other review before I noticed it was abandoned: Some whitespace changes snuck in. Please remove them from this functional commit..

erj added inline comments.May 3 2023, 12:23 AM

sys/net/iflib.c
2516	This could've been a separate patch -- but I noticed that both sctx and scctx are referring to the same structure in ctx, so I just changed things to just use one of them. I'm not sure what the original intent for sctx was.
6863–6864	Krzysztof suggested this when I let him review this patch, too. I was worried about how Jeff would apply it if it were more than one patch (that's why it was two but I combined it into one), but the documentation does say that `arc patch` should automatically pull the predecessors in a patch stack, so maybe that wasn't necessary. I'll pull the whitespace/alignment changes out, anyway.

Split changes out into different Differential revisions for easier review

Harbormaster completed remote builds in B52984: Diff 125599.Aug 4 2023, 6:12 PM

erj added a parent revision: D41326: iflib: Add sysctl to request extra MSIX vectors on driver load.Aug 4 2023, 6:13 PM

erj retitled this revision from iflib: Add helper functions for subinterface creation to iflib: Add subinterface interrupt allocation function.

erj edited the summary of this revision. (Show Details)

erj added a reviewer: Intel Networking.

erj edited the summary of this revision. (Show Details)

@jeffrey.e.pieper_intel.com Applying this revision using "arc patch" should pull all the parent revisions, too, but we'll have to double check to make sure.

sys/net/iflib.c
2516	This change was moved to D41325 to provide more clarity.
6863–6864	I moved non-functional whitespace changes to D41324.

Any new thoughts on this review or the previous one in the stack? I'd like to get these in for 14.0-RELEASE.

@erj can you post the draft driver update, I'd like to see how it intends to use this patch stack before commentary

Rebase on latest main; remove whitespace error

Harbormaster completed remote builds in B56141: Diff 134777.Feb 21 2024, 5:23 AM

Update value used for IFLIB_FEATURE_SUB_INTERFACES

Harbormaster completed remote builds in B56142: Diff 134778.Feb 21 2024, 5:26 AM

erj added a child revision: D44003: ice(4): Update copyright year to 2024.Feb 21 2024, 5:29 AM

In D39930#943725, @kbowling wrote:

@erj can you post the draft driver update, I'd like to see how it intends to use this patch stack before commentary

It's very late, but it's here: https://reviews.freebsd.org/D44004. This review and that one are part of the same Phabricator patch stack now.

This revision was not accepted when it landed; it landed in state Needs Review.Apr 18 2024, 11:24 PM

Closed by commit rGed34a6b6eab9: iflib: Add subinterface interrupt allocation function (authored by erj). · Explain Why

This revision was automatically updated to reflect the committed changes.

erj added a commit: rGed34a6b6eab9: iflib: Add subinterface interrupt allocation function.

erj added a commit: rG59d1c385f681: iflib: Add subinterface interrupt allocation function.Apr 24 2024, 10:15 PM

erj added a commit: rG67c30c246d16: iflib: Add subinterface interrupt allocation function.Jul 31 2024, 4:39 AM