Differential D42179

netlink: move NETLINK define to opt_global.h
ClosedPublic
Actions

Authored by kp on Oct 12 2023, 8:07 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Jul 18, 8:37 AM

	Unknown Object (File)
	Sat, Jul 18, 4:15 AM

	Unknown Object (File)
	Sat, Jul 18, 3:47 AM

	Unknown Object (File)
	Fri, Jul 17, 9:43 AM

	Unknown Object (File)
	Wed, Jul 15, 8:28 PM

	Unknown Object (File)
	Jun 11 2026, 2:17 PM

	Unknown Object (File)
	Jun 10 2026, 7:53 PM

	Unknown Object (File)
	Jun 10 2026, 1:43 AM

Subscribers

Details

Reviewers

markj
imp
melifaro

Group Reviewers

Commits

rG2ae26ba67338: netlink: move NETLINK define to opt_global.h
rGff15498894e2: netlink: move NETLINK define to opt_global.h
rGab393e9548f8: netlink: move NETLINK define to opt_global.h

Summary

Move the NETLINK define into opt_global.h so we can rely on it being
set correctly, without having to remember to include opt_netlink.h.
This ensures that the NETLINK define is correctly set. If not we
may end up with unloadable modules, due to missing symbols (such as
nlmsg_get_group_writer).

PR: 274306
MFC after: 3 days

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 53952
Build 50842: arc lint + arc unit

Event Timeline

kp created this revision.Oct 12 2023, 8:07 PM

Herald added subscribers: glebius, farrokhi, ae. · View Herald TranscriptOct 12 2023, 8:07 PM

kp requested review of this revision.Oct 12 2023, 8:07 PM

Harbormaster completed remote builds in B53952: Diff 128688.Oct 12 2023, 8:07 PM

kp mentioned this in D42170: netlink: include opt_netlink.h.Oct 12 2023, 8:09 PM

imp accepted this revision.Oct 12 2023, 9:06 PM

This revision is now accepted and ready to land.Oct 12 2023, 9:06 PM

markj accepted this revision as: markj.Oct 12 2023, 11:06 PM

Closed by commit rGab393e9548f8: netlink: move NETLINK define to opt_global.h (authored by kp). · Explain WhyOct 13 2023, 7:26 AM

This revision was automatically updated to reflect the committed changes.

kp added a commit: rGab393e9548f8: netlink: move NETLINK define to opt_global.h.

kp mentioned this in D42171: ip_carp: remove opt_netlink.h include.Oct 13 2023, 7:27 AM

kp mentioned this in D42172: pf: remove opt_netlink.h include.

kp added a commit: rGff15498894e2: netlink: move NETLINK define to opt_global.h.Oct 16 2023, 11:32 AM

kp added a commit: rG2ae26ba67338: netlink: move NETLINK define to opt_global.h.Oct 17 2023, 5:58 AM

Revision Contents
Changeset List

Path

Size

sys/

compat/

linux/

linux_netlink.c

1 line

conf/

2 lines

modules/

carp/

2 lines

ktest/

ktest/

1 line

ktest_example/

1 line

ktest_netlink_message_writer/

1 line

linux/

3 lines

linux_common/

3 lines

netlink/

2 lines

net/

2 lines

1 line

netinet/

2 lines

netlink/

ktest_netlink_message_writer.c

2 lines

netlink_domain.c

1 line

netlink_generic.c

2 lines

2 lines

2 lines

netlink_message_writer.c

2 lines

netlink_module.c

2 lines

route/

2 lines

iface_drivers.c

1 line

2 lines

2 lines

2 lines

netpfil/

pf/

2 lines

tests/

2 lines

Diff 128688

sys/compat/linux/linux_netlink.c

Loading...

sys/conf/options

Loading...

sys/modules/carp/Makefile

Loading...

sys/modules/ktest/ktest/Makefile

Loading...

sys/modules/ktest/ktest_example/Makefile

Loading...

sys/modules/ktest/ktest_netlink_message_writer/Makefile

Loading...

sys/modules/linux/Makefile

Loading...

sys/modules/linux_common/Makefile

Loading...

sys/modules/netlink/Makefile

Loading...

sys/net/if_clone.c

Loading...

sys/net/if_vlan.c

Loading...

sys/netinet/ip_carp.c

Loading...

sys/netlink/ktest_netlink_message_writer.c

Loading...

sys/netlink/netlink_domain.c

Loading...

sys/netlink/netlink_generic.c

Loading...

sys/netlink/netlink_glue.c

Loading...

sys/netlink/netlink_io.c

Loading...

sys/netlink/netlink_message_writer.c

Loading...

sys/netlink/netlink_module.c

Loading...

sys/netlink/route/iface.c

Loading...

sys/netlink/route/iface_drivers.c

Loading...

sys/netlink/route/neigh.c

Loading...

sys/netlink/route/nexthop.c

Loading...

sys/netlink/route/rt.c

Loading...

sys/netpfil/pf/pf_nl.c

Loading...

sys/tests/ktest.c

Loading...