ip_carp: remove opt_netlink.h include
AbandonedPublic
Actions

Authored by kp on Oct 12 2023, 5:29 PM.

Tags

None

Referenced Files

	F163212405: D42171.diff
	Tue, Jul 21, 2:43 AM

	Unknown Object (File)
	Thu, Jul 16, 12:13 AM

	Unknown Object (File)
	Tue, Jul 7, 2:23 AM

	Unknown Object (File)
	Mon, Jul 6, 11:45 PM

	Unknown Object (File)
	Jun 13 2026, 2:11 AM

	Unknown Object (File)
	Jun 12 2026, 7:05 PM

	Unknown Object (File)
	Jun 11 2026, 5:42 PM

	Unknown Object (File)
	Apr 27 2026, 2:29 PM

Subscribers

Details

Reviewers

markj

Group Reviewers

network

Summary

netlink.h now includes it directly, so we don't need to do that here.

MFC after: 3 days

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 53943
Build 50833: arc lint + arc unit

Event Timeline

kp created this revision.Oct 12 2023, 5:29 PM

Herald added subscribers: glebius, melifaro, imp. · View Herald TranscriptOct 12 2023, 5:29 PM

kp requested review of this revision.Oct 12 2023, 5:29 PM

Harbormaster completed remote builds in B53943: Diff 128675.Oct 12 2023, 5:29 PM

kp added a parent revision: D42170: netlink: include opt_netlink.h.Oct 12 2023, 5:29 PM

kp added a child revision: D42172: pf: remove opt_netlink.h include.

markj accepted this revision as: markj.Oct 12 2023, 6:24 PM

This revision is now accepted and ready to land.Oct 12 2023, 6:24 PM

Why is netlink.h including it directly? That usually is a layering violation

D42179 was committed instead.

Revision Contents
Changeset List

Path

Size

sys/

netinet/

ip_carp.c

2 lines

Diff 128675

View Options

ip_carp: remove opt_netlink.h includeAbandonedPublicActions