Page MenuHomeFreeBSD
Differential D41850

virtio: remove virtio_alloc_virtqueues' flags arg
ClosedPublic
Actions

Authored by freebsd_igalic.co on Sep 13 2023, 10:37 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jun 4, 11:07 AM
Unknown Object (File)
Thu, Jun 4, 11:07 AM
Unknown Object (File)
Fri, May 15, 11:38 AM
Unknown Object (File)
Fri, May 15, 11:38 AM
Unknown Object (File)
Fri, May 15, 11:16 AM
Unknown Object (File)
Fri, May 15, 11:16 AM
Unknown Object (File)
Fri, May 15, 4:32 AM
Unknown Object (File)
Thu, May 14, 9:56 PM
View All Files
Subscribers
cognet
imp

Details

Reviewers
bryanv
Commits
rG180c02405b12: virtio: remove virtio_alloc_virtqueues' flags arg
Summary

the flags argument is unused.
Its initial design idea has been superceded by the addition of
virtio_setup_intr and related APIs.

Sponsored by: The FreeBSD Foundation

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 53577
Build 50468: arc lint + arc unit

Event Timeline

freebsd_igalic.co created this revision.Sep 13 2023, 10:37 PM
Herald added a subscriber: imp. · View Herald TranscriptSep 13 2023, 10:37 PM
freebsd_igalic.co requested review of this revision.Sep 13 2023, 10:37 PM
freebsd_igalic.co added a parent revision: D41849: virtio: add comment on the spec for vring struct.
Harbormaster completed remote builds in B53577: Diff 127349.Sep 13 2023, 10:37 PM
freebsd_igalic.co added a child revision: D41851: virtio: start simple, document virtio_endian(9).Sep 13 2023, 10:39 PM
freebsd_igalic.co added reviewers: bryanv, jrtc27.Sep 13 2023, 11:16 PM

adding bryanv and jrtc27 as reviewers, hope they have time for this.

freebsd_igalic.co removed a reviewer: jrtc27.Sep 13 2023, 11:20 PM

removing jrtc27 again, as per IRC, she's:

<jrtc27> I'm away from friday

freebsd_igalic.co added a comment.Sep 13 2023, 11:40 PM

remotely related: https://github.com/freebsd/freebsd-src/pull/827

freebsd_igalic.co updated this revision to Diff 127373.Sep 14 2023, 10:37 AM
freebsd_igalic.co added a subscriber: cognet.

thanks to @cognet for catching this rebase botch

bryanv accepted this revision.Sep 15 2023, 3:46 AM
This revision is now accepted and ready to land.Sep 15 2023, 3:46 AM
Closed by commit rG180c02405b12: virtio: remove virtio_alloc_virtqueues' flags arg (authored by freebsd_igalic.co, committed by cognet). · Explain WhySep 18 2023, 8:05 PM
This revision was automatically updated to reflect the committed changes.
cognet added a commit: rG180c02405b12: virtio: remove virtio_alloc_virtqueues' flags arg.
freebsd_igalic.co added a comment.Sep 21 2023, 12:50 PM

Should this be MFC'd?
is it it safe?
are there any third-party vendors who might stumble over this API change?

dch mentioned this in D41844: Add an implementation of the 9P filesystem.Sep 23 2023, 11:33 AM

Revision Contents
Changeset List

PathSize
sys/
dev/
virtio/
balloon/
2 lines
block/
2 lines
console/
2 lines
gpu/
2 lines
mmio/
4 lines
network/
12 lines
pci/
2 lines
2 lines
4 lines
4 lines
random/
2 lines
scsi/
2 lines
2 lines
5 lines
1 line

Diff 127349

View Options

sys/dev/virtio/balloon/virtio_balloon.c

Loading...
View Options

sys/dev/virtio/block/virtio_blk.c

Loading...
View Options

sys/dev/virtio/console/virtio_console.c

Loading...
View Options

sys/dev/virtio/gpu/virtio_gpu.c

Loading...
View Options

sys/dev/virtio/mmio/virtio_mmio.c

Loading...
View Options

sys/dev/virtio/network/if_vtnet.c

Loading...
View Options

sys/dev/virtio/pci/virtio_pci.h

Loading...
View Options

sys/dev/virtio/pci/virtio_pci.c

Loading...
View Options

sys/dev/virtio/pci/virtio_pci_legacy.c

Loading...
View Options

sys/dev/virtio/pci/virtio_pci_modern.c

Loading...
View Options

sys/dev/virtio/random/virtio_random.c

Loading...
View Options

sys/dev/virtio/scsi/virtio_scsi.c

Loading...
View Options

sys/dev/virtio/virtio.h

Loading...
View Options

sys/dev/virtio/virtio.c

Loading...
View Options

sys/dev/virtio/virtio_bus_if.m

Loading...