Differential D36400

tcp: remove INP_TIMEWAIT flag
ClosedPublic
Actions

Authored by glebius on Aug 31 2022, 5:12 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Feb 16, 7:28 PM

	Unknown Object (File)
	Mon, Feb 16, 2:17 PM

	Unknown Object (File)
	Mon, Feb 16, 2:16 PM

	Unknown Object (File)
	Tue, Feb 10, 8:41 PM

	Unknown Object (File)
	Tue, Feb 10, 8:41 PM

	Unknown Object (File)
	Tue, Feb 10, 1:10 AM

	Unknown Object (File)
	Mon, Feb 2, 1:13 PM

	Unknown Object (File)
	Jan 10 2026, 7:57 PM

Subscribers

Details

Reviewers

Group Reviewers

Commits

rG53af69038164: tcp: remove INP_TIMEWAIT flag

Summary

Mechanically cleanup INP_TIMEWAIT from the kernel sources. After
the step 1, this commit shall not cause any functional changes.

Note: this flag was very often checked together with INP_DROPPED.
If we modify in_pcblookup*() not to return INP_DROPPED pcbs, we
will be able to remove most of this checks and turn them to
assertions. Some of them can be turned into assertions right now,
but that should be carefully done on a case by case basis.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 47194
Build 44081: arc lint + arc unit

Event Timeline

glebius created this revision.Aug 31 2022, 5:12 AM

Herald added 1 blocking reviewer(s): transport. · View Herald TranscriptAug 31 2022, 5:12 AM

Herald added subscribers: melifaro, ae, imp. · View Herald Transcript

glebius requested review of this revision.Aug 31 2022, 5:12 AM

Harbormaster completed remote builds in B47194: Diff 110006.Aug 31 2022, 5:12 AM

glebius added a parent revision: D36399: tcp: in tcp_usr_detach() remove special handling of compressed time-wait.Aug 31 2022, 5:12 AM

glebius retitled this revision from tcp: remove compressed timewait state structure, step 2 to tcp: remove INP_TIMEWAIT flag.Oct 5 2022, 4:59 PM

Rebase, improve commit message.

Harbormaster completed remote builds in B47704: Diff 111478.Oct 5 2022, 5:04 PM

tuexen accepted this revision.Oct 7 2022, 12:10 PM

This revision is now accepted and ready to land.Oct 7 2022, 12:10 PM

Committed 53af69038164

glebius added a commit: rG53af69038164: tcp: remove INP_TIMEWAIT flag.May 28 2023, 2:37 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

cxgbe/

crypto/

4 lines

cxgbei/

4 lines

11 lines

iw_cxgbe/

2 lines

tom/

10 lines

2 lines

4 lines

kern/

19 lines

netinet/

7 lines

9 lines

10 lines

6 lines

6 lines

3 lines

tcp_stacks/

2 lines

2 lines

21 lines

8 lines

54 lines

2 lines

netinet6/

3 lines

8 lines

netipsec/

4 lines

Diff 110006

sys/dev/cxgbe/crypto/t6_kern_tls.c

Loading...

sys/dev/cxgbe/cxgbei/cxgbei.c

Loading...

sys/dev/cxgbe/cxgbei/icl_cxgbei.c

Loading...

sys/dev/cxgbe/iw_cxgbe/qp.c

Loading...

sys/dev/cxgbe/tom/t4_cpl_io.c

Loading...

sys/dev/cxgbe/tom/t4_ddp.c

Loading...

sys/dev/cxgbe/tom/t4_tls.c

Loading...

sys/kern/uipc_ktls.c

Loading...

sys/netinet/in_pcb.h

Loading...

sys/netinet/in_pcb.c

Loading...

sys/netinet/siftr.c

Loading...

sys/netinet/tcp_hpts.c

Loading...

sys/netinet/tcp_log_buf.c

Loading...

sys/netinet/tcp_lro.c

Loading...

sys/netinet/tcp_stacks/bbr.c

Loading...

sys/netinet/tcp_stacks/rack.c

Loading...

sys/netinet/tcp_subr.c

Loading...

sys/netinet/tcp_timer.c

Loading...

sys/netinet/tcp_usrreq.c

Loading...

sys/netinet/toecore.c

Loading...

sys/netinet6/in6_pcb.c

Loading...

sys/netinet6/ip6_output.c

Loading...

sys/netipsec/xform_tcp.c

Loading...