ifnet: if_vmove_reclaim(): Be more robust to check the src / dst vnet
AbandonedPublic
Actions

Authored by zlei on Tue, Mar 17, 4:56 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Apr 8, 9:55 AM

	Unknown Object (File)
	Sun, Apr 5, 1:21 PM

	Unknown Object (File)
	Wed, Apr 1, 3:29 AM

	Unknown Object (File)
	Mon, Mar 30, 8:49 AM

	Unknown Object (File)
	Sat, Mar 28, 2:15 AM

	Unknown Object (File)
	Fri, Mar 27, 7:13 AM

	Unknown Object (File)
	Fri, Mar 27, 7:13 AM

	Unknown Object (File)
	Mon, Mar 23, 6:29 AM

Subscribers

Details

Reviewers

glebius

Group Reviewers

network

Summary

The ifp is only weak referenced, if_vmove_reclaim() may race with other
threads' if_vmove() or if_detach(), hence ifp->if_vnet is not safe nor
stable to access. Given we know the source and destination prison/vnet,
check them instead.

MFC after: 2 weeks

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

zlei created this revision.Tue, Mar 17, 4:56 PM

Herald added subscribers: melifaro, ae, imp. · View Herald TranscriptTue, Mar 17, 4:56 PM

zlei requested review of this revision.Tue, Mar 17, 4:56 PM

zlei mentioned this in D55832: ifnet: if_vmove_(loan|reclaim): Refactor a bit the checking of src / dst vnet.

zlei abandoned this revision.Fri, Mar 20, 6:56 PM

zlei added inline comments.

sys/net/if.c
1286	This assert is wrong. Post fix to D55997.

Revision Contents
Changeset List

Path

Size

sys/

net/

if.c

18 lines

Diff 173813

View Options

ifnet: if_vmove_reclaim(): Be more robust to check the src / dst vnetAbandonedPublicActions