Differential D40262
Allow setting a per-Jail fallback ABI brand. Authored by nyan_myuji.xyz on May 25 2023, 4:16 AM. Tags Referenced Files
Details Similar to kern.elfXX.fallback_brand sysctl, this allow setting a fallback ELF32/64 Useful in running statically linked Penguin binaries with wrong ABI value in Event: Kitchener-Waterloo Hackathon 202305
Diff Detail
Event Timeline
Comment Actions Rather than add a separate value different from the kern.fallback_elf_brand sysctl, it would make sense for the jail parameter to be tied to the sysctl itself, such as the securelevel parameter is. It's complicated somewhat by the fact that there are three similar sysctls. Comment Actions I think that will be a good idea. However right now the kern.elfXX.fallback_elf_brand are tied to 2 global variables which their name are generated by the __elfN(xxx) macro. We could technically remove them and tie all 3 to the jail one? Maybe that belongs to a separate review? Comment Actions Interesting. I didn't expect that kern.fallback_elf_brand was a just an alias for kern.elfXX.fallback_brand. But then I also didn't expect it would have a comment /* XXX compatibility, remove for 6.0 */ ;-). This does complicate things, since you can't just use struct prison for dynamic sysctls like the per-arch elf fallbacks, but would need to use OSD(9) instead. So yes, perhaps that's something for another review. But then, since there's not a non-arch-specific fallback value (though ther kern.fallback_elf_brand sysctl alias makes it look like there is), I'm not sure we should be introducing one for jail only. But maybe it would be good to make such a global fallback, tied to the jail as I mention, and use kern.fallback_elf_brand for that. And then perhaps that old XXX comment could go away.
Comment Actions The overall idea seems ok to me for what it's worth, my comments are about cosmetic issues.
| |||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||