device: add device_get_property and device_has_property

[bag_semihalf.com]

Summary

Generialize bus specific property accessors. Those functions allow driver code
to access device specific information.

Currently there is only support for FDT and ACPI buses.

[manu]

LGTM but that should be documented somewhere (tm)

[imp]

This really needs man pages, but otherwise looks OK to me module one nit in bus.h

sys/kern/bus_if.m

957

This needs a man page.

sys/kern/subr_bus.c

2718

This needs a man page.

sys/sys/bus.h

640

I'd move the implementation of this to subr_bus.c. There's no need for it to be inline and it's the only function like that here.
this also needs a man page :)

[bag_semihalf.com]

I've created requested man pages.

[bag_semihalf.com]

@imp Did you have time to look at these man pages?

[bz]

Sorry; post-commit comment for enhancement.

sys/dev/acpica/acpi.c

1852

I believe you need a

default:
    return (0);

here; otherwise if the type is not handled here, device_has_property() will get a -1 result and return "no such property" rather than "property exists".

sys/kern/subr_bus.c

2722

This is not correct. But the real problem is elsehere (see other comment on acpi.c).

[bag_semihalf.com]

In D31597#744282, @bz wrote:

Sorry; post-commit comment for enhancement.

Thank you for the comment. I will work on this next week.

[bz]

In D31597#746777, @bag_semihalf.com wrote:

In D31597#744282, @bz wrote:

Sorry; post-commit comment for enhancement.

Thank you for the comment. I will work on this next week.

FYI I have further changes to use the handle internally for _DSD as some non-native ACPI devices (no _HID) can then also use these functions (directly) to get properties; I'll extract them and post them and try to Cc: you. And maybe you guys have better ways to handle that; I hit the problem with MDI0/PHY and PR<n>s for dpaa2.

[mw]

In D31597#746913, @bz wrote:

In D31597#746777, @bag_semihalf.com wrote:

In D31597#744282, @bz wrote:

Sorry; post-commit comment for enhancement.

Thank you for the comment. I will work on this next week.

FYI I have further changes to use the handle internally for _DSD as some non-native ACPI devices (no _HID) can then also use these functions (directly) to get properties; I'll extract them and post them and try to Cc: you. And maybe you guys have better ways to handle that; I hit the problem with MDI0/PHY and PR<n>s for dpaa2.

Please add me to all related dpaa2/MDIO/PHY/ACPI-related reviews.

Thank you in advance,
Marcin