Page MenuHomeFreeBSD

acpi: Call SPMC entry/exit hooks if SPMC device is set
Needs ReviewPublic

Authored by obiwac_gmail.com on Jan 30 2025, 7:07 PM.
Tags
None
Referenced Files
F111353747: D48735.diff
Sun, Mar 2, 6:20 PM
Unknown Object (File)
Wed, Feb 26, 9:42 PM
Unknown Object (File)
Wed, Feb 26, 10:30 AM
Unknown Object (File)
Tue, Feb 25, 8:12 AM
Unknown Object (File)
Tue, Feb 25, 5:32 AM
Unknown Object (File)
Wed, Feb 12, 2:15 AM
Unknown Object (File)
Sat, Feb 8, 10:55 AM
Unknown Object (File)
Fri, Feb 7, 12:14 PM

Details

Reviewers
jhb
imp
jkim
Summary

Calls SPMC entry notification hook if acpi_spmc_device exists on the ACPI driver context before going to sleep, and calls the SPMC exit notification hook after we've woken up.

See D48387.

Test Plan

Framework 13 AMD Ryzen 7040 series enters a standby mode (power button led fades in and out slowly).

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 62165
Build 59049: arc lint + arc unit

Event Timeline

obiwac_gmail.com created this revision.

Suspend works on my Lenovo notebook. After resume there is no response to pressing keyboard keys in the console, but switching between terminals works.

Awesome! I'll start work on reading residency counters on Intel (though the LPIT) soon, so we can check if the CPU is actually entering S0i3 on Intel :)

As per your keyboard issue, since switching between terminals works, I'm assuming this is not per se a driver issue - I guess this needs more work to debug. Does the keyboard still work after resuming in an X or Wayland session?

Does the keyboard still work after resuming in an X or Wayland session?

I tested it without X session and i915kms loaded because screen remains black in an X session after resume.