Page MenuHomeFreeBSD

sdhci_xenon: add ACPI support
ClosedPublic

Authored by bag_semihalf.com on Aug 18 2021, 8:52 AM.

Details

Summary

Add support for ACPI device probing for SDHCI controller found on Marvell chips.

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

sys/conf/files.arm64
279

Add in alphabetical order.

sys/dev/sdhci/sdhci_xenon_acpi.c
87

Don't mix assignments with declarations - please revisit entire file.

100

Add comment, that in ACPI world the firmware is responsible for configuring the regulators.

103

This will disappear after moving max_clk handling to sdhci_xenon_attach

104

slot->quirks = 0; is done twice.

110

This will disappear after moving max_clk handling to sdhci_xenon_attach

119

No need to assign NULL values - sc fields are zeroed by default.

mw requested changes to this revision.Sep 23 2021, 11:01 AM
This revision now requires changes to proceed.Sep 23 2021, 11:01 AM
bag_semihalf.com marked 7 inline comments as done.

LGTM + tested on (with DT and ACPI) on: MacchiatoBin, CN913x-DB and CN913x-CEx7 Evaluation Board

sys/dev/sdhci/sdhci_xenon_acpi.c
100

Above assignments are done in a common part, I'll remove while committing.

This revision is now accepted and ready to land.Wed, Sep 29, 1:23 PM
This revision was automatically updated to reflect the committed changes.