Paths

Table of Contentst

Differential D31600

sdhci_xenon: add ACPI support
ClosedPublic
Actions

Authored by bag_semihalf.com on Aug 18 2021, 8:52 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Apr 21, 11:47 PM

	Unknown Object (File)
	Sun, Apr 21, 11:47 PM

	Unknown Object (File)
	Sun, Apr 21, 11:47 PM

	Unknown Object (File)
	Sun, Apr 21, 11:47 PM

	Unknown Object (File)
	Sun, Apr 21, 9:34 PM

	Unknown Object (File)
	Sat, Apr 20, 7:27 AM

	Unknown Object (File)
	Fri, Apr 19, 3:23 PM

	Unknown Object (File)
	Feb 16 2024, 11:15 AM

View All 44 Files

Subscribers

dgr_semihalf.com

Details

Reviewers

wma
mw
manu
mmel

Commits

rG993cd606c238: sdhci_xenon: add ACPI support
rGadbce5ff747b: sdhci_xenon: add ACPI support

Summary

Add support for ACPI device probing for SDHCI controller found on Marvell chips.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bag_semihalf.com created this revision.Aug 18 2021, 8:52 AM

Herald added subscribers: emaste, andrew. · View Herald TranscriptAug 18 2021, 8:52 AM

bag_semihalf.com requested review of this revision.Aug 18 2021, 8:52 AM

bag_semihalf.com added a parent revision: D31599: sdhci_xenon: split driver file into generic file and fdt parts.

mw added inline comments.Sep 23 2021, 11:01 AM

sys/conf/files.arm64
280	Add in alphabetical order.
sys/dev/sdhci/sdhci_xenon_acpi.c
88	Don't mix assignments with declarations - please revisit entire file.
101	Add comment, that in ACPI world the firmware is responsible for configuring the regulators.
104	This will disappear after moving max_clk handling to sdhci_xenon_attach
105	`slot->quirks = 0;` is done twice.
111	This will disappear after moving max_clk handling to sdhci_xenon_attach
120	No need to assign NULL values - sc fields are zeroed by default.

mw requested changes to this revision.Sep 23 2021, 11:01 AM

This revision now requires changes to proceed.Sep 23 2021, 11:01 AM

bag_semihalf.com updated this revision to Diff 95615.Sep 24 2021, 9:26 AM

bag_semihalf.com marked 7 inline comments as done.

LGTM + tested on (with DT and ACPI) on: MacchiatoBin, CN913x-DB and CN913x-CEx7 Evaluation Board

sys/dev/sdhci/sdhci_xenon_acpi.c
101	Above assignments are done in a common part, I'll remove while committing.

This revision is now accepted and ready to land.Sep 29 2021, 1:23 PM

Closed by commit rGadbce5ff747b: sdhci_xenon: add ACPI support (authored by bag_semihalf.com, committed by mw). · Explain WhySep 29 2021, 2:21 PM

This revision was automatically updated to reflect the committed changes.

mw added a commit: rGadbce5ff747b: sdhci_xenon: add ACPI support.

mw added a commit: rG993cd606c238: sdhci_xenon: add ACPI support.Mar 29 2022, 11:02 PM

Herald added a subscriber: imp. · View Herald TranscriptMar 29 2022, 11:02 PM

Revision Contents
Changeset List

Path

Size

sys/

conf/

1 line

dev/

sdhci/

sdhci_xenon_acpi.c

140 lines

Diff 95937

sys/conf/files.arm64

Loading...

sys/dev/sdhci/sdhci_xenon_acpi.c

Loading...