Page MenuHomeFreeBSD

sdhci_xenon: add ACPI support
ClosedPublic

Authored by bag_semihalf.com on Aug 18 2021, 8:52 AM.
Tags
None
Referenced Files
F81709569: D31600.diff
Sat, Apr 20, 7:27 AM
Unknown Object (File)
Fri, Apr 19, 3:23 PM
Unknown Object (File)
Feb 16 2024, 11:15 AM
Unknown Object (File)
Feb 16 2024, 11:13 AM
Unknown Object (File)
Feb 16 2024, 11:13 AM
Unknown Object (File)
Feb 16 2024, 11:13 AM
Unknown Object (File)
Feb 16 2024, 4:27 AM
Unknown Object (File)
Jan 29 2024, 1:54 PM

Details

Summary

Add support for ACPI device probing for SDHCI controller found on Marvell chips.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

sys/conf/files.arm64
280

Add in alphabetical order.

sys/dev/sdhci/sdhci_xenon_acpi.c
88

Don't mix assignments with declarations - please revisit entire file.

101

Add comment, that in ACPI world the firmware is responsible for configuring the regulators.

104

This will disappear after moving max_clk handling to sdhci_xenon_attach

105

slot->quirks = 0; is done twice.

111

This will disappear after moving max_clk handling to sdhci_xenon_attach

120

No need to assign NULL values - sc fields are zeroed by default.

mw requested changes to this revision.Sep 23 2021, 11:01 AM
This revision now requires changes to proceed.Sep 23 2021, 11:01 AM
bag_semihalf.com marked 7 inline comments as done.

LGTM + tested on (with DT and ACPI) on: MacchiatoBin, CN913x-DB and CN913x-CEx7 Evaluation Board

sys/dev/sdhci/sdhci_xenon_acpi.c
101

Above assignments are done in a common part, I'll remove while committing.

This revision is now accepted and ready to land.Sep 29 2021, 1:23 PM
This revision was automatically updated to reflect the committed changes.