Sep 15 2025
There's a report of touchpad breakage that traced back to this commit: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=289353
Sep 13 2025
Aug 13 2025
Committed with a few more cleanups.
Aug 6 2025
Aug 4 2025
Looks mostly sane and the issues I remember flagging before have been corrected.
Jul 29 2025
Jul 28 2025
LGTM
Jul 27 2025
Closing this, continuation in https://reviews.freebsd.org/D51568
Jul 26 2025
Was this superseded by later reviews?
Jul 20 2025
May we omit the prompt characters in the examples section of tcopy.1 for copy paste?
i'm not a simh-tapefile expert, so I've not verified that this implements that standard.
I do like the cleanup generally and have only a few questions / suggestions.
Jul 14 2025
May 7 2025
Apr 18 2025
Apr 2 2025
Dec 12 2024
Oct 16 2024
rebasing with minor additional changes before I begin the work to split this up
Oct 13 2024
Interim PR changes while I work on splitting this up to different sub PRs. Don't want my work lost
Oct 12 2024
Oct 7 2024
I think the cycle detection patch is fine and should be committed on its own. If you send me (markj@freebsd.org) a patch with that piece of the change, I'll commit it.
Oct 6 2024
Sep 21 2024
Possible to get some eyes on this and see if we can get this across?
With many apologies for the delay, this is now sent.
Sep 10 2024
This undoes the fix done in c6d3d601c96f5836df76847, which hurts real users.
Sep 9 2024
Sep 8 2024
Sep 7 2024
Undo damage done in c6d3d601c96f, which shifted failure to allocate large buffer to pipe_create() from pipe_write().
Sep 6 2024
Sep 3 2024
Make harmless.
P.S. I think this whole new "behaviour" is the (unintended?) consequence of the c6d3d601c, which shifted the failure to allocate buffer from the write() call into the popen() call. Which added the whole new failure mode into fork()->exec() mechanism that can be easily triggered by anybody. So no new process can be created even if the new process and/or its parent would never want to write or read to the pipe in a normal conditions.
Aug 30 2024
@kib thanks for the input. Beefed up telemetry, as suggested, removed the reference to tuning. Added option to kill the repeated offender (or an innocent bystander ;-)