Page MenuHomeFreeBSD

Src CommittersOrganization
ActivePublic

Recent Activity

Sep 15 2025

markj added a comment to D51302: Avoid split I²C transactions in iichid.

There's a report of touchpad breakage that traced back to this commit: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=289353

Sep 15 2025, 1:06 PM · Src Committers

Sep 13 2025

bofh added a member for Src Committers: jaeyoon.
Sep 13 2025, 10:40 AM

Aug 13 2025

phk closed D51568: (almost) rewrite tcopy(1) to teach it new tricks..

Committed with a few more cleanups.

Aug 13 2025, 7:24 AM · Src Committers

Aug 6 2025

david_crossfamilyweb.com added a comment to D38047: Multiple fixes to the NSS caching system.
In D38047#1177323, @des wrote:

Was this superseded by later reviews?

Aug 6 2025, 11:02 PM · Src Committers

Aug 4 2025

imp accepted D51568: (almost) rewrite tcopy(1) to teach it new tricks..

Looks mostly sane and the issues I remember flagging before have been corrected.

Aug 4 2025, 6:20 PM · Src Committers

Jul 29 2025

phk closed D51302: Avoid split I²C transactions in iichid.
Jul 29 2025, 6:22 AM · Src Committers

Jul 28 2025

wulf accepted D51302: Avoid split I²C transactions in iichid.

LGTM

Jul 28 2025, 10:52 PM · Src Committers

Jul 27 2025

phk updated the summary of D51568: (almost) rewrite tcopy(1) to teach it new tricks..
Jul 27 2025, 9:24 AM · Src Committers
phk requested review of D51568: (almost) rewrite tcopy(1) to teach it new tricks..
Jul 27 2025, 9:24 AM · Src Committers
phk abandoned D51442: Refactor tcopy(1) and teach it about SIMH-TAPFILE format.

Closing this, continuation in https://reviews.freebsd.org/D51568

Jul 27 2025, 9:24 AM · Src Committers

Jul 26 2025

des added a comment to D38047: Multiple fixes to the NSS caching system.

Was this superseded by later reviews?

Jul 26 2025, 5:59 AM · Src Committers

Jul 20 2025

ziaee added a comment to D51442: Refactor tcopy(1) and teach it about SIMH-TAPFILE format.

May we omit the prompt characters in the examples section of tcopy.1 for copy paste?

Jul 20 2025, 10:52 PM · Src Committers
imp added a comment to D51442: Refactor tcopy(1) and teach it about SIMH-TAPFILE format.

i'm not a simh-tapefile expert, so I've not verified that this implements that standard.
I do like the cleanup generally and have only a few questions / suggestions.

Jul 20 2025, 3:43 PM · Src Committers
phk requested review of D51442: Refactor tcopy(1) and teach it about SIMH-TAPFILE format.
Jul 20 2025, 2:57 PM · Src Committers

Jul 14 2025

phk requested review of D51302: Avoid split I²C transactions in iichid.
Jul 14 2025, 3:00 PM · Src Committers

May 7 2025

bofh added a member for Src Committers: kgalazka.
May 7 2025, 7:54 PM

Apr 18 2025

bofh added a member for Src Committers: ivy.
Apr 18 2025, 10:56 PM

Apr 2 2025

des requested changes to D38047: Multiple fixes to the NSS caching system.
Apr 2 2025, 9:09 AM · Src Committers

Dec 12 2024

allanjude added a reviewer for D38047: Multiple fixes to the NSS caching system: Klara.
Dec 12 2024, 1:44 PM · Src Committers

Oct 16 2024

david_crossfamilyweb.com updated the diff for D38047: Multiple fixes to the NSS caching system.

rebasing with minor additional changes before I begin the work to split this up

Oct 16 2024, 1:13 AM · Src Committers

Oct 13 2024

david_crossfamilyweb.com added inline comments to D38047: Multiple fixes to the NSS caching system.
Oct 13 2024, 6:45 PM · Src Committers
markj added inline comments to D38047: Multiple fixes to the NSS caching system.
Oct 13 2024, 2:30 PM · Src Committers
david_crossfamilyweb.com updated the diff for D38047: Multiple fixes to the NSS caching system.

Interim PR changes while I work on splitting this up to different sub PRs. Don't want my work lost

Oct 13 2024, 1:01 AM · Src Committers
david_crossfamilyweb.com added inline comments to D38047: Multiple fixes to the NSS caching system.
Oct 13 2024, 12:56 AM · Src Committers

Oct 12 2024

markj added inline comments to D38047: Multiple fixes to the NSS caching system.
Oct 12 2024, 3:41 PM · Src Committers

Oct 7 2024

markj added a comment to D38047: Multiple fixes to the NSS caching system.

I think the cycle detection patch is fine and should be committed on its own. If you send me (markj@freebsd.org) a patch with that piece of the change, I'll commit it.

Oct 7 2024, 1:41 PM · Src Committers

Oct 6 2024

arrowd added inline comments to D38047: Multiple fixes to the NSS caching system.
Oct 6 2024, 7:37 PM · Src Committers

Sep 21 2024

david_crossfamilyweb.com added a comment to D38047: Multiple fixes to the NSS caching system.

Possible to get some eyes on this and see if we can get this across?

Sep 21 2024, 7:48 PM · Src Committers
markj closed D45056: support for DIRECT access via ggated and ggatec.
Sep 21 2024, 1:06 PM · Src Committers
david_crossfamilyweb.com added a comment to D45056: support for DIRECT access via ggated and ggatec.

With many apologies for the delay, this is now sent.

Sep 21 2024, 7:37 AM · Src Committers

Sep 10 2024

olce added a comment to D46472: Make pipe(2) & Co bullet-proof again (PR 272332).

Undo damage done in c6d3d601c96f, which shifted failure to allocate large buffer to pipe_create() from pipe_write().

The need for such allocation by itself is questionable since absolute majority of users write less than dozen bytes and out of that majority most write exactly 0.

Sep 10 2024, 4:56 PM · Src Committers
kib added a comment to D46472: Make pipe(2) & Co bullet-proof again (PR 272332).
In D46472#1062498, @kib wrote:

This undoes the fix done in c6d3d601c96f5836df76847, which hurts real users.

Whatever band-aids you would try to put on top of the issue, it cannot solve the fundamental inability of computers to allocate infinite amount of resources. Perhaps, the only clean way to isolate one user from mal-acting neighbor is to implement per-uid pipe limit (RLIMIT_PIPEN), which is not that useless IMO.

Sep 10 2024, 4:19 AM · Src Committers
kib added a comment to D46472: Make pipe(2) & Co bullet-proof again (PR 272332).

This undoes the fix done in c6d3d601c96f5836df76847, which hurts real users.

Sep 10 2024, 3:12 AM · Src Committers

Sep 9 2024

sobomax retitled D46472: Make pipe(2) & Co bullet-proof again (PR 272332) from Make popen() bullet-proof again (PR 272332) to Make pipe(2) & Co bullet-proof again (PR 272332).
Sep 9 2024, 2:55 PM · Src Committers

Sep 8 2024

david_crossfamilyweb.com added a comment to D45056: support for DIRECT access via ggated and ggatec.

How should I submit this to you for the path; I have never used git format-patch before; I tried doing git format-patch main and it generated 21 files (since I have 21 commits). Manpage suggests I email this to you? But it seems rude to just blast you with 21 patches; and I don't know your email.

David, did you still need more help here?

Sep 8 2024, 1:41 AM · Src Committers

Sep 7 2024

sobomax updated the summary of D46472: Make pipe(2) & Co bullet-proof again (PR 272332).
Sep 7 2024, 3:46 AM · Src Committers
sobomax updated the summary of D46472: Make pipe(2) & Co bullet-proof again (PR 272332).
Sep 7 2024, 2:31 AM · Src Committers
sobomax updated the diff for D46472: Make pipe(2) & Co bullet-proof again (PR 272332).

Undo damage done in c6d3d601c96f, which shifted failure to allocate large buffer to pipe_create() from pipe_write().

Sep 7 2024, 2:26 AM · Src Committers

Sep 6 2024

sobomax updated the summary of D46472: Make pipe(2) & Co bullet-proof again (PR 272332).
Sep 6 2024, 11:06 PM · Src Committers
sobomax retitled D46472: Make pipe(2) & Co bullet-proof again (PR 272332) from Add little debug to help tracking pipebombs to Make popen() bullet-proof again (PR 272332).
Sep 6 2024, 11:05 PM · Src Committers
sobomax planned changes to D46472: Make pipe(2) & Co bullet-proof again (PR 272332).
Sep 6 2024, 11:00 PM · Src Committers
sobomax added inline comments to D46472: Make pipe(2) & Co bullet-proof again (PR 272332).
Sep 6 2024, 10:57 PM · Src Committers
allanjude added a comment to D45056: support for DIRECT access via ggated and ggatec.

How should I submit this to you for the path; I have never used git format-patch before; I tried doing git format-patch main and it generated 21 files (since I have 21 commits). Manpage suggests I email this to you? But it seems rude to just blast you with 21 patches; and I don't know your email.

Sep 6 2024, 12:42 PM · Src Committers
kib added inline comments to D46472: Make pipe(2) & Co bullet-proof again (PR 272332).
Sep 6 2024, 5:10 AM · Src Committers

Sep 3 2024

sobomax added a reviewer for D46472: Make pipe(2) & Co bullet-proof again (PR 272332): mjg.
Sep 3 2024, 7:13 PM · Src Committers
sobomax updated the diff for D46472: Make pipe(2) & Co bullet-proof again (PR 272332).

Make harmless.

Sep 3 2024, 7:13 PM · Src Committers
sobomax added a comment to D46472: Make pipe(2) & Co bullet-proof again (PR 272332).

P.S. I think this whole new "behaviour" is the (unintended?) consequence of the c6d3d601c, which shifted the failure to allocate buffer from the write() call into the popen() call. Which added the whole new failure mode into fork()->exec() mechanism that can be easily triggered by anybody. So no new process can be created even if the new process and/or its parent would never want to write or read to the pipe in a normal conditions.

Sep 3 2024, 5:01 PM · Src Committers
sobomax added inline comments to D46472: Make pipe(2) & Co bullet-proof again (PR 272332).
Sep 3 2024, 4:28 PM · Src Committers

Aug 30 2024

kib added inline comments to D46472: Make pipe(2) & Co bullet-proof again (PR 272332).
Aug 30 2024, 9:19 PM · Src Committers
sobomax added a comment to D46472: Make pipe(2) & Co bullet-proof again (PR 272332).

@kib thanks for the input. Beefed up telemetry, as suggested, removed the reference to tuning. Added option to kill the repeated offender (or an innocent bystander ;-)

Aug 30 2024, 7:20 AM · Src Committers