• Wordsmith

Remove password prompt from the example

• address feedback (I answered some of the comments directly or at least marked them as done)
• sort copyright header

I have been testing this again recently, and it works fine, at least with the tests I ran. I think we should go ahead and get it into the tree, it's been sitting in review for 3 years almost. releng/15.0 is branched so there is no fear of breaking the release, even though this shouldn't break anything in the first place, it's a kinst-specific change and at worst it won't always yield 100% correct results. Once we have it in tree we can work on remaining issues, but I do not see a point in keeping it here anymore.

In D39259#1136450, @markj wrote:

I think this is subsumed by commit 5bd7b976c1214cd6357b74f491753a331f9b7c99.

• UMA -> uma

Closed via 9388c2887817d7162ebb356b39aa9b4ab67a8c00.

Thanks, Mark!

• Add the enum to the definition

Great! Thanks for explaining, Mark :)

Please don't commit this. It's not necessary, and you're just hard-coding internal values from the kernel. The fplookup result status number is just an implementation detail and isn't part of any stable interface.

In D51315#1172217, @0mp wrote:

In D51315#1172185, @markj wrote:

Another side note: wouldn't it be nice to create a vfs.d in /usr/lib/dtrace so that we could use the actual enum for arg2 instead of integers? The enum would be:

Just change the type from int to enum cache_fpl_status in the probe definition, and it'll work. dtrace knows about enum names since they're encoded in CTF info.

ah, so the actual fix should be:

SDT_PROBE_DEFINE3(vfs, fplookup, lookup, done, "struct nameidata *", "enum cache_fpl_status", "bool");

do I understand correctly?

I'm not sure if that would work. DTrace seems to not know about the the constants like CACHE_FPL_STATUS_DESTROYED at all. How would the type change fix that? I'll try that later. Maybe DTrace does some magic that makes it work.

Alternatively, I've opened another revision that adds the enum to libdtrace/vfs.d, but I suspect that this is not the right fix based on Mark's last comment.

In D51315#1172185, @markj wrote:

Another side note: wouldn't it be nice to create a vfs.d in /usr/lib/dtrace so that we could use the actual enum for arg2 instead of integers? The enum would be:

Just change the type from int to enum cache_fpl_status in the probe definition, and it'll work. dtrace knows about enum names since they're encoded in CTF info.

Another side note: wouldn't it be nice to create a vfs.d in /usr/lib/dtrace so that we could use the actual enum for arg2 instead of integers? The enum would be:

We can of course fix them later, but I did send a mail asking about how we write the synopsis. These SYNOPSIS(es?) do introduce bugs in apropos results.

• Pet mdoc linters

• Address Christos' feedback

Thanks!

• Capitalize descriptions of aggregation functions

@ziaee, could you check the apropos(1) compliance? ;)

• Address feedback

I haven't checked mandoc -Tlint, but make sure there are no errors there as well.

Thanks!

• Address feedback

• Address bcr's comments

• Add bcr's comments