Jan 10 2024
Jan 2 2024
Missing comma in man page.
Address @markj's comments.
Dec 28 2023
Dec 22 2023
Overall I think this is in good shape and can land soon. Thank you for writing test cases and thorough documentation. My inline comments are just nitpicking for the man page.
If I compile usr.sbin/dtrace with this patch applied, I get:
Dec 8 2023
Update the diff to address a few output alignment issues when not using structured output via xo_emit(). Without the added xo_flush() calls, the output from xo_emit() would be printed after all the other output is printed via fprintf(). Also added a comment explaining why xo_flush() is called in those situations.
Nov 1 2023
That's pretty terrible, given that all flavors of xo_emit* turn into the same codepath (xo_do_emit). Can you isolate this into something I can debug, or send me your current patch (phil@freebsd.org) and I'll see if I can do it?
$ sudo dtrace -n 'BEGIN { mod(0xffffffff8261a000); exit(0); }'
dtrace: description 'BEGIN ' matched 1 probe
CPU ID FUNCTION:NAME6 1 :BEGIN opensolaris.ko
@phil I've tried to do a basic implementation using xo_create_to_file and then implementing dt_emit() by redirecting buffered output and sprintf output to the regular printf output (it becomes dt_vprintf since i have a va_list instead of variadic arguments). However, I've noticed that if I do regular text output using
Oct 29 2023
Oct 23 2023
Oct 20 2023
Oct 19 2023
Update the diff. This diff should address the following:
Oct 18 2023
Oct 16 2023
Sep 23 2023
Fix off->val type causing a build failure.
Sep 15 2023
Fix struct indentation.
Sep 8 2023
Add missing information to the man page and fix some bits in it (e.g. using .Fn for action names).
Updated the diff with documentation in the dtrace(1) man page, as well as a bug fix when it comes to naming aggregations. Namely, min, max, sum and count were all called count in the final output due to missing checks. These are now addressed.
Sep 7 2023
Please address the comments from markj@ but otherwise this looks good, and more extensive than what we came up with on CADETS.
I suggest to think about adding --libxo foo as an alias to -x oformat=foo to make things more inline with what is actually done for, e.g., netstat(1).
Sep 6 2023
Attempt #2 at addressing @markj's comments... Forgot one gettimeofday
Address some comments by @markj. The man page comment is still true, as I will be updating that when all the documentation comes in.
I don't see a reason to avoid adding it to dtrace.1?
Perhaps its own man page is warranted in order to avoid polluting dtrace(1)?
Sep 5 2023
Aug 27 2023
Fix return offset handling.
Aug 25 2023
Jul 19 2023
Jul 16 2023
Address comments, fix stuff that was also fixed in riscv.
Jul 14 2023
Jul 13 2023
Update