Updated the diff with documentation in the dtrace(1) man page, as well as a bug fix when it comes to naming aggregations. Namely, min, max, sum and count were all called count in the final output due to missing checks. These are now addressed.

Fri, Sep 8, 12:16 AM · DTrace

Thu, Sep 7

gnn accepted D41745: dtrace: Add the 'oformat' libdtrace option..

Please address the comments from markj@ but otherwise this looks good, and more extensive than what we came up with on CADETS.

Thu, Sep 7, 1:10 PM · DTrace

domagoj.stolfa_gmail.com added a comment to D41745: dtrace: Add the 'oformat' libdtrace option..

In D41745#951858, @stephane.rochoy_stormshield.eu wrote:

I suggest to think about adding --libxo foo as an alias to -x oformat=foo to make things more inline with what is actually done for, e.g., netstat(1).

Thu, Sep 7, 12:15 PM · DTrace

stephane.rochoy_stormshield.eu added a comment to D41745: dtrace: Add the 'oformat' libdtrace option..

I suggest to think about adding --libxo foo as an alias to -x oformat=foo to make things more inline with what is actually done for, e.g., netstat(1).

Thu, Sep 7, 6:19 AM · DTrace

Wed, Sep 6

domagoj.stolfa_gmail.com updated the diff for D41745: dtrace: Add the 'oformat' libdtrace option..

Attempt #2 at addressing @markj's comments... Forgot one gettimeofday

Wed, Sep 6, 6:25 PM · DTrace

domagoj.stolfa_gmail.com updated the diff for D41745: dtrace: Add the 'oformat' libdtrace option..

Address some comments by @markj. The man page comment is still true, as I will be updating that when all the documentation comes in.

Wed, Sep 6, 6:21 PM · DTrace

domagoj.stolfa_gmail.com added a comment to D41745: dtrace: Add the 'oformat' libdtrace option..

I don't see a reason to avoid adding it to dtrace.1?

Wed, Sep 6, 5:18 PM · DTrace

markj added a comment to D41745: dtrace: Add the 'oformat' libdtrace option..

Perhaps its own man page is warranted in order to avoid polluting dtrace(1)?

Wed, Sep 6, 2:46 PM · DTrace

Tue, Sep 5

domagoj.stolfa_gmail.com updated the summary of D41745: dtrace: Add the 'oformat' libdtrace option..

Tue, Sep 5, 8:58 PM · DTrace

domagoj.stolfa_gmail.com updated the summary of D41745: dtrace: Add the 'oformat' libdtrace option..

Tue, Sep 5, 8:38 PM · DTrace

domagoj.stolfa_gmail.com requested review of D41745: dtrace: Add the 'oformat' libdtrace option..

Tue, Sep 5, 8:36 PM · DTrace

Aug 27 2023

christos updated the diff for D38825: libdtrace: implement inline function tracing for kinst.

Fix return offset handling.

Aug 27 2023, 3:28 PM · DTrace

Aug 25 2023

imp closed D41595: dtrace: Remove $FreeBSD$ from genmakefiles.sh..

Aug 25 2023, 8:58 PM · DTrace

imp accepted D41595: dtrace: Remove $FreeBSD$ from genmakefiles.sh..

Aug 25 2023, 6:59 PM · DTrace

domagoj.stolfa_gmail.com requested review of D41595: dtrace: Remove $FreeBSD$ from genmakefiles.sh..

Aug 25 2023, 6:35 PM · DTrace

Jul 19 2023

christos closed D40337: kinst: port to arm64.

Jul 19 2023, 3:01 PM · arm64, DTrace

christos added inline comments to D40337: kinst: port to arm64.

Jul 19 2023, 2:11 PM · arm64, DTrace

markj accepted D40337: kinst: port to arm64.

Approved.

Jul 19 2023, 1:47 PM · arm64, DTrace

Jul 16 2023

christos updated the diff for D40337: kinst: port to arm64.

Address comments, fix stuff that was also fixed in riscv.

Jul 16 2023, 4:28 PM · arm64, DTrace

Jul 14 2023

markj added inline comments to D40337: kinst: port to arm64.

Jul 14 2023, 2:03 PM · arm64, DTrace

Jul 13 2023

christos updated the diff for D39259: fbt: allow tracing of dtrace_test.ko functions.

Update

Jul 13 2023, 10:27 PM · DTrace

christos retitled D39259: fbt: allow tracing of dtrace_test.ko functions from fbt(4): allow tracing in dtrace_test.ko if it was loaded after fbt to fbt: allow tracing of dtrace_test.ko functions.

Jul 13 2023, 10:24 PM · DTrace

christos updated the summary of D40337: kinst: port to arm64.

Jul 13 2023, 10:11 PM · arm64, DTrace

christos updated the diff for D40337: kinst: port to arm64.

Address Mark's comments. Depends on D40962.

Jul 13 2023, 10:11 PM · arm64, DTrace

markj added inline comments to D40337: kinst: port to arm64.

Jul 13 2023, 6:34 PM · arm64, DTrace

christos added inline comments to D40337: kinst: port to arm64.

Jul 13 2023, 6:12 PM · arm64, DTrace

markj added inline comments to D40337: kinst: port to arm64.

Jul 13 2023, 5:50 PM · arm64, DTrace

Jul 12 2023

christos updated the diff for D40337: kinst: port to arm64.

Disable adr/adrp emulation.

Jul 12 2023, 12:38 PM · arm64, DTrace

Jul 10 2023

christos updated the diff for D40337: kinst: port to arm64.

Use per-probe trampolines. Depends on D40962

Jul 10 2023, 8:42 PM · arm64, DTrace

Jul 7 2023

christos updated the diff for D40337: kinst: port to arm64.

Updated description, still some unsolved bugs, but mostly done.

Jul 7 2023, 5:36 PM · arm64, DTrace

Jul 4 2023

markj added a comment to D39884: kinst: port to riscv.

In D39884#930242, @jrtc27 wrote:

In D39884#930234, @christos wrote:

In D39884#930225, @mhorne wrote:

In D39884#928340, @markj wrote:

This provider can trigger what appears to be a QEMU/TCG bug. The test case:

boot a riscv VM with more than one vCPU

run dtrace -q -n 'kinst::riscv_cpu_intr:', i.e., trace all instructions in riscv_cpu_intr()

Seems I was a bit slow to report my findings, but I did observe some of the same kinds of panics on real hardware that I saw in QEMU. I will update to the committed version and provide a more detailed answer of what is still not working.

Can you recompile kinst with this patch applied? https://reviews.freebsd.org/P592
If we run it with a single trampoline per page, the crashes seem to go away.

Is it just a case of needing to smp_rendezvous a fence_i since it's not broadcast by the hardware like on arm64?

Jul 4 2023, 5:03 PM · riscv, DTrace

christos added a comment to D39884: kinst: port to riscv.

In D39884#930242, @jrtc27 wrote:

Is it just a case of needing to smp_rendezvous a fence_i since it's not broadcast by the hardware like on arm64?

Jul 4 2023, 4:55 PM · riscv, DTrace

jrtc27 added a comment to D39884: kinst: port to riscv.

In D39884#930234, @christos wrote:

In D39884#930225, @mhorne wrote:

In D39884#928340, @markj wrote:

This provider can trigger what appears to be a QEMU/TCG bug. The test case:

boot a riscv VM with more than one vCPU

run dtrace -q -n 'kinst::riscv_cpu_intr:', i.e., trace all instructions in riscv_cpu_intr()

Seems I was a bit slow to report my findings, but I did observe some of the same kinds of panics on real hardware that I saw in QEMU. I will update to the committed version and provide a more detailed answer of what is still not working.

Can you recompile kinst with this patch applied? https://reviews.freebsd.org/P592
If we run it with a single trampoline per page, the crashes seem to go away.

Jul 4 2023, 4:40 PM · riscv, DTrace

christos added a comment to D39884: kinst: port to riscv.

In D39884#930225, @mhorne wrote:

In D39884#928340, @markj wrote:

This provider can trigger what appears to be a QEMU/TCG bug. The test case:

boot a riscv VM with more than one vCPU

run dtrace -q -n 'kinst::riscv_cpu_intr:', i.e., trace all instructions in riscv_cpu_intr()

Seems I was a bit slow to report my findings, but I did observe some of the same kinds of panics on real hardware that I saw in QEMU. I will update to the committed version and provide a more detailed answer of what is still not working.

Jul 4 2023, 4:11 PM · riscv, DTrace

christos updated the diff for D38825: libdtrace: implement inline function tracing for kinst.

Updates.

Jul 4 2023, 4:03 PM · DTrace

markj added a comment to D39884: kinst: port to riscv.

In D39884#930225, @mhorne wrote:

In D39884#928340, @markj wrote:

This provider can trigger what appears to be a QEMU/TCG bug. The test case:

boot a riscv VM with more than one vCPU

run dtrace -q -n 'kinst::riscv_cpu_intr:', i.e., trace all instructions in riscv_cpu_intr()

Seems I was a bit slow to report my findings, but I did observe some of the same kinds of panics on real hardware that I saw in QEMU. I will update to the committed version and provide a more detailed answer of what is still not working.

Jul 4 2023, 3:58 PM · riscv, DTrace

mhorne added a comment to D39884: kinst: port to riscv.

In D39884#928340, @markj wrote:

This provider can trigger what appears to be a QEMU/TCG bug. The test case:

boot a riscv VM with more than one vCPU

run dtrace -q -n 'kinst::riscv_cpu_intr:', i.e., trace all instructions in riscv_cpu_intr()