Page MenuHomeFreeBSD
Differential D39259

fbt: Allow tracing of dtrace_test.ko functions
AbandonedPublic
Actions

Authored by christos on Mar 24 2023, 6:25 PM.
Tags
Referenced Files
Unknown Object (File)
Fri, Oct 10, 1:37 PM
Unknown Object (File)
Fri, Oct 10, 12:05 AM
Unknown Object (File)
Thu, Oct 9, 2:43 PM
Unknown Object (File)
Fri, Oct 3, 12:14 PM
Unknown Object (File)
Thu, Oct 2, 4:19 AM
Unknown Object (File)
Tue, Sep 30, 4:23 AM
Unknown Object (File)
Tue, Sep 30, 1:34 AM
Unknown Object (File)
Wed, Sep 24, 7:00 PM
View All Files
Subscribers
domagoj.stolfa_gmail.com
imp

Details

Reviewers
markj
domagoj.stolfa_gmail.com

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 52638
Build 49529: arc lint + arc unit

Event Timeline

christos created this revision.Mar 24 2023, 6:25 PM
Herald added a subscriber: imp. · View Herald TranscriptMar 24 2023, 6:25 PM
christos requested review of this revision.Mar 24 2023, 6:25 PM
christos added a child revision: D38825: libdtrace: Implement inline function tracing for kinst.
christos added a parent revision: D40874: kinst.4: Update man page.Jul 4 2023, 9:59 AM
christos removed a parent revision: D40874: kinst.4: Update man page.
christos retitled this revision from fbt(4): allow tracing in dtrace_test.ko if it was loaded after fbt to fbt: allow tracing of dtrace_test.ko functions.Jul 13 2023, 10:24 PM
christos edited the summary of this revision. (Show Details)
christos updated this revision to Diff 124646.Jul 13 2023, 10:27 PM

Update

Harbormaster completed remote builds in B52638: Diff 124646.Jul 13 2023, 10:28 PM
christos retitled this revision from fbt: allow tracing of dtrace_test.ko functions to fbt: Allow tracing of dtrace_test.ko functions.Jan 9 2025, 12:24 PM
domagoj.stolfa_gmail.com accepted this revision.Apr 15 2025, 6:50 PM
domagoj.stolfa_gmail.com added a subscriber: domagoj.stolfa_gmail.com.
domagoj.stolfa_gmail.com added inline comments.
sys/cddl/dev/fbt/fbt.c
201

"... we want to be able to trace for testing purposes." perhaps? Seems somewhat redundant given that the name of the kernel module is dtrace_test.ko so I'm fine with it either way.

This revision is now accepted and ready to land.Apr 15 2025, 6:50 PM
markj added a comment.Apr 15 2025, 7:22 PM

I think this is subsumed by commit 5bd7b976c1214cd6357b74f491753a331f9b7c99.

christos abandoned this revision.Sep 11 2025, 12:12 PM
In D39259#1136450, @markj wrote:

I think this is subsumed by commit 5bd7b976c1214cd6357b74f491753a331f9b7c99.

Yes.

Revision Contents
Changeset List

PathSize
sys/
cddl/
dev/
fbt/
17 lines

Diff 124646

View Options

sys/cddl/dev/fbt/fbt.c

Loading...