Unless I'm mistaken this is several fixes, not all of which are related to CUBIC, but contained in a single patch. Please split these out into separate changes, in particular the mathematical equation change in cc_cubic.h. While I believe that the math change there is correct (from reading the latest draft) I'd like it to be possible to revert that one change simply if it proves to be an issue.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Dec 6 2016
Dec 6 2016
gnn retitled D8718: Fix a kernel panic in DTrace's rw_iswriter subroutine.
On FreeBSD the sense of rw_write_held() and rw_iswriter() were reversed probably due
to a cut and paste error. Using rw_iswriter() would cause the kernel to panic. from to Fix a kernel panic in DTrace's rw_iswriter subroutine.
On FreeBSD the sense of rw_write_held() and rw_iswriter() were reversed probably due
to a cut and paste error. Using rw_iswriter() would cause the kernel to panic..
Nov 28 2016
Nov 28 2016
Nov 23 2016
Nov 23 2016
Add tunable to disable destructive dtrace
gnn retitled D8624: Add tunable to disable destructive dtrace
Security from to Add tunable to disable destructive dtrace
Security.
Nov 19 2016
Nov 19 2016
Update distinfo to match the Makefile version
Nov 18 2016
Nov 18 2016
Improve timing and fix a race condition
Nov 5 2016
Nov 5 2016
Update the port to the latest version moved to the freebsd-net github…
Nov 3 2016
Nov 3 2016
A few of us discussed this today in the transport conference call. hps@ will have an update based on that discussion. The gist is that np@, hps@ and other NIC facing folks should make the decision on how to use the fields.
Oct 28 2016
Oct 28 2016
Corrected non-portable reuse of va_list in dt_printf()
I think this is a good addition.
Oct 22 2016
Oct 22 2016
I am confused by the question about the manual page. That can be put under a separate review if you like.
Oct 19 2016
Oct 19 2016
We have 100G hardware at Sentex on the Mercats. I can free those hosts up for you.
A quick note that function calls are definitely the preferred solution.
Oct 17 2016
Oct 17 2016
Limit the number of mbufs that can be allocated for IPV6_2292PKTOPTIONS
Note that this port is broken on FreeBSD 9.
Looks good to me. I can commit this if you like.
Oct 11 2016
Oct 11 2016
Corrected non-portable reuse of va_list in dt_printf()
Oct 10 2016
Oct 10 2016
Oct 7 2016
Oct 7 2016
Undo accidental inclusion of packetdrill update in tcptestsuite commit
Add a port for a set of scripts to test TCP using packetdrill
Oct 5 2016
Oct 5 2016
Address comments from markj@
gnn retitled D8157: Corrected non-portable reuse of va_list in dt_printf() from to Corrected non-portable reuse of va_list in dt_printf().
Oct 3 2016
Oct 3 2016
gnn accepted D8072: Remove an extraneous call to soisconnected() in syncache_socket(), introduced with r261242..
LGTM
Oct 1 2016
Oct 1 2016
Do we have a document on how the packaging for base works? I'd like to understand the process a bit better before approving this review.
Sep 30 2016
Sep 30 2016
I'd like a reference to what these will actually do. It seems that each library is now a package but that may not make sense based on the structure of those libraries.
Sep 28 2016
Sep 28 2016
I'd prefer a broad, cleanup commit.
This looks correct to me.
Sep 24 2016
Sep 24 2016
Sep 20 2016
Sep 20 2016
Sep 15 2016
Sep 15 2016
I will test and commit this one.
Sep 14 2016
Sep 14 2016
Sep 12 2016
Sep 12 2016
Sep 3 2016
Sep 3 2016
Add cpuset support to separate forked processes.
I've address the main issues.
Sep 2 2016
Sep 2 2016
Address issue of too many threads.
Add a runner script for cryptotest.
gnn retitled D7766: Add cpuset(2) support to sepearate forked processes. from to Add cpuset(2) support to sepearate forked processes..
Clean up the usage message and remove dead code.
Add support for using cpuset to spearate forked processes.
Remove dead code.
gnn retitled D7765: Update help and remove support for arc4 from to Update help and remove support for arc4.
Aug 30 2016
Aug 30 2016
Update cryptotest for modern algorithms
Aug 29 2016
Aug 29 2016
Address more comments.
Aug 25 2016
Aug 25 2016
gnn closed D7648: Unlike Solaris, in FreeBSD p_args can be NULL so check for that before checking ar_args..
Committed revision 304825.
Unlike Solaris, in FreeBSD p_args can be 0 so check for that
gnn updated the diff for D7648: Unlike Solaris, in FreeBSD p_args can be NULL so check for that before checking ar_args..
jhb@ reports that if p_args is non 0 then ar_args will be valid.
gnn updated the diff for D7648: Unlike Solaris, in FreeBSD p_args can be NULL so check for that before checking ar_args..
Tighten up the logic.
gnn retitled D7648: Unlike Solaris, in FreeBSD p_args can be NULL so check for that before checking ar_args. from to Unlike Solaris, in FreeBSD p_args can be NULL so check for that before checking ar_args..
Aug 23 2016
Aug 23 2016
I guess my other fear is that the address might overlap an existing allocation. What is the use case for random MACs?
I am somewhat confused. I don't see anything about random addresses in the RFC mentioned in the followup.
There is no reason for the functions to be static at all, so removing them just cleans up the code and makes it trivially debuggable.
Aug 22 2016
Aug 22 2016
gnn retitled D7598: Update cryptotest for modern algorithms. from to Update cryptotest for modern algorithms..
Aug 18 2016
Aug 18 2016
Remove the obsolete and unused openbsd_poll system call. (Phase 2)
Remove unusedd and obsolete openbsd_poll system call. (Phase 1)
Add the version update
Aug 17 2016
Aug 17 2016
Address issues pointed out by brooks@
gnn retitled D7548: Remove the obsolete openbsd_poll system call. from to Remove the obsolete openbsd_poll system call..
Chuck this one because arc.
Remove the obsolete opebsd_poll system call.
Aug 16 2016
Aug 16 2016
A few points about how we put code into FreeBSD.
Aug 11 2016
Aug 11 2016
Aug 2 2016
Aug 2 2016
Address issue pointed out by markj
Jul 29 2016
Jul 29 2016
Jul 27 2016
Jul 27 2016
Accepted. Go for it.
Jul 25 2016
Jul 25 2016
Jul 11 2016
Jul 11 2016
Jul 8 2016
Jul 8 2016
On FreeBSD there is a setsockopt option SO_USER_COOKIE which allows
I'll make that change in the commit.
gnn retitled D7152: Add support for the user cookie to DTrace and TCP from to Add support for the user cookie to DTrace and TCP.
Jul 6 2016
Jul 6 2016
gnn added reviewers for D7144: Corrected non-portable reuse of va_list in dt_printf(): markj, rwatson.
gnn retitled D7144: Corrected non-portable reuse of va_list in dt_printf() from to Corrected non-portable reuse of va_list in dt_printf().
gnn retitled D7143: corrected non-portable reuse of va_list in dt_printf() from to corrected non-portable reuse of va_list in dt_printf().