fix sooptcopyin on big-endian platforms (e.g. MIPS64EB)
ClosedPublic
Actions

Authored by br on Sep 20 2016, 2:42 PM.

Tags

None

Referenced Files

	F110640408: D7980.id20540.diff
	Fri, Feb 21, 7:52 AM

	Unknown Object (File)
	Wed, Feb 19, 1:17 PM

	Unknown Object (File)
	Fri, Feb 7, 12:07 PM

	Unknown Object (File)
	Wed, Feb 5, 4:34 AM

	Unknown Object (File)
	Jan 12 2025, 11:54 PM

	Unknown Object (File)
	Jan 10 2025, 1:23 AM

	Unknown Object (File)
	Jan 6 2025, 4:33 AM

	Unknown Object (File)
	Dec 5 2024, 5:07 AM

View All 47 Files

Subscribers

None

Details

Reviewers

wollman
gnn

Group Reviewers

network

Commits

rS306186: Adjust the sopt_val pointer on bigendian systems (e.g. MIPS64EB).

Summary

sooptcopyin checks if size of data provided by user is <= 4 bytes to fit optval (which is int). If size of data is bigger than 4 bytes then it strips down the size to 4.
On bigendian platforms we have to move pointer as well so we copy the actual data.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

br updated this revision to Diff 20540.Sep 20 2016, 2:42 PM

br retitled this revision from to fix sooptcopyin on big-endian platforms (e.g. MIPS64EB).

br updated this object.

br edited the test plan for this revision. (Show Details)

br added reviewers: wollman, network.

gnn accepted this revision.Sep 20 2016, 3:04 PM

gnn added a reviewer: gnn.

This revision is now accepted and ready to land.Sep 20 2016, 3:04 PM

Closed by commit rS306186: Adjust the sopt_val pointer on bigendian systems (e.g. MIPS64EB). (authored by br). · Explain WhySep 22 2016, 12:42 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

kern/

uipc_socket.c

6 lines

Diff 20616

View Options

head/sys/kern/uipc_socket.c

fix sooptcopyin on big-endian platforms (e.g. MIPS64EB)ClosedPublicActions