Prepare for network stack as a module.

[stevek]

Summary

• Move cr_canseeinpcb to sys/netinet/in_prot.c in order to separate the INET and INET6-specific code from the rest of the prot code (It is only used by the network stack, so it makes sense for it to live with the other network stack code.)
• Move cr_canseeinpcb prototype from sys/systm.h to netinet/in_systm.h
• Rename cr_seeotheruids to cr_canseeotheruids and cr_seeothergids to cr_canseeothergids, make them non-static, and add prototypes (so they can be see/called by in_prot.c functions.)
• Remove sw_csum variable from ip6_forward in ip6_forward.c, as it is an unused variable.

Obtained from: Juniper Networks, Inc.

[gnn]

This looks fine but I'm hoping that bz@ (now added) will take a look as well.

[bz]

To me this sounds like a convolution of a couple of changes.

Can we get the moves of the functions, then rename them for consistency maybe, and then do the iocgroup change. That'll help to understand things and move forward more easily.

[stevek]

I assume you mean splitting the prot changes from the ioctl group bits?
Would you prefer two (or three) new Phabricator reviews for that or use this one for one of the reviews?

[stevek]

Trimmed down to first smaller piece.

[stevek]

ping.

[gnn]

Accepted. Go for it.

Best,
George