Page MenuHomeFreeBSD

marcel (Marcel Moolenaar)
User

Projects

User Details

User Since
Oct 21 2014, 4:41 PM (243 w, 1 d)

Recent Activity

Mar 23 2019

marcel committed rS345436: MFC 344826:.
MFC 344826:
Mar 23 2019, 3:37 AM
marcel added a reverting change for rS254095: gpt_entries is used as limit for the number of partition entries in: rS345434: MFC 344790:.
Mar 23 2019, 3:10 AM
marcel committed rS345434: MFC 344790:.
MFC 344790:
Mar 23 2019, 3:10 AM

Mar 22 2019

marcel committed rS345428: MFC 344826:.
MFC 344826:
Mar 22 2019, 11:55 PM
marcel committed rS345427: MFC 344790:.
MFC 344790:
Mar 22 2019, 11:39 PM
marcel added a reverting change for rS254095: gpt_entries is used as limit for the number of partition entries in: rS345427: MFC 344790:.
Mar 22 2019, 11:39 PM

Mar 9 2019

marcel committed rS344957: Don't compress and uuencode the "hexdump -C" output files. Just.
Don't compress and uuencode the "hexdump -C" output files. Just
Mar 9 2019, 2:03 AM

Mar 5 2019

marcel committed rS344826: Round # partitions up to fill the last GPT table sector.
Round # partitions up to fill the last GPT table sector
Mar 5 2019, 10:55 PM
marcel closed D19465: Round # partitions up to fill the last GPT table sector.
Mar 5 2019, 10:55 PM
marcel added a comment to D19465: Round # partitions up to fill the last GPT table sector.

Yeah, I don't like the way we now have the master files. I think I was too much focussed on keeping the file size small and opted to compress, followed by uuencode. But it's a real pain to work with. For one, you can't diff the rebased files after a code change and see if the new behavior matches the expectation. And on top of that, diffs tend to be much bigger than a one-liner of the hexdump output.

Mar 5 2019, 10:23 PM
marcel created D19465: Round # partitions up to fill the last GPT table sector.
Mar 5 2019, 5:50 AM
marcel closed D19438: Revert revision 254095.
Mar 5 2019, 4:15 AM
marcel committed rS344790: Revert revision 254095.
Revert revision 254095
Mar 5 2019, 4:15 AM
marcel added a reverting change for rS254095: gpt_entries is used as limit for the number of partition entries in: rS344790: Revert revision 254095.
Mar 5 2019, 4:15 AM

Mar 3 2019

marcel created D19438: Revert revision 254095.
Mar 3 2019, 6:13 PM

Jan 26 2019

marcel committed rP491318: Upgrade to openiked-2.1.
Upgrade to openiked-2.1
Jan 26 2019, 11:48 PM
marcel closed D18907: Upgrade to openiked-2.1..
Jan 26 2019, 11:48 PM
marcel added a comment to D18907: Upgrade to openiked-2.1..

Thanks for pointing out that OpenSSL 1.0.x needs to be supported.
OpenIKED 2.1 has support for OpenSSL 1.0.x and OpenSSL 1.1.x.

Jan 26 2019, 6:22 AM
marcel retitled D18907: Upgrade to openiked-2.1. from Upgrade to openiked-2.0a to Upgrade to openiked-2.1..
Jan 26 2019, 6:21 AM
marcel updated the diff for D18907: Upgrade to openiked-2.1..

Upgrade to openiked-2.1

Jan 26 2019, 6:19 AM
marcel added inline comments to D18907: Upgrade to openiked-2.1..
Jan 26 2019, 12:32 AM

Jan 20 2019

marcel updated the summary of D18907: Upgrade to openiked-2.1..
Jan 20 2019, 11:39 PM
marcel created D18907: Upgrade to openiked-2.1..
Jan 20 2019, 11:23 PM

May 2 2018

marcel accepted D15266: gpart: add fat32lba MBR partition type.

LGTM

May 2 2018, 8:09 PM

Feb 23 2018

marcel added a comment to D14494: The console name has to match the /dev name for /dev/console to work..

This is opposite the direction taken already. The low-level console is defined in terms of hardware resources only. The uart(4) driver will map the low-level console to the newbus device during bus enumeration. The unit number is not a hardware resource. It's a newbus device property.

Feb 23 2018, 11:59 PM

Feb 17 2018

marcel accepted D14397: vt_vga: check if VGA is available from ACPI FADT table.

LGTM.

Feb 17 2018, 5:20 PM

Feb 5 2018

marcel accepted D14210: Rationalize license test on Linuxolator files.

I'm ok with the changes. I'll trust Ed to give others a chance to chime in. Speculatively accepting the revision on everyone's behalf.

Feb 5 2018, 9:16 PM

Dec 2 2017

marcel committed rS326477: MFC r324369.
MFC r324369
Dec 2 2017, 6:41 PM

Nov 27 2017

marcel committed rP454989: Upgrade to openiked-1.10.
Upgrade to openiked-1.10
Nov 27 2017, 7:55 PM
marcel closed D13159: Upgrade to openiked-1.10.
Nov 27 2017, 7:55 PM
marcel accepted D13159: Upgrade to openiked-1.10.
Nov 27 2017, 7:54 PM

Nov 19 2017

marcel created D13159: Upgrade to openiked-1.10.
Nov 19 2017, 5:37 PM

Oct 6 2017

marcel committed rS324369: Fix alignment of 'last' in autofill..
Fix alignment of 'last' in autofill.
Oct 6 2017, 4:38 PM

Sep 22 2017

marcel committed rP450383: Upgrade to openiked-1.9.
Upgrade to openiked-1.9
Sep 22 2017, 3:23 PM
marcel closed D12443: Upgrade to openiked-1.9.
Sep 22 2017, 3:23 PM

Sep 21 2017

marcel created D12443: Upgrade to openiked-1.9.
Sep 21 2017, 9:57 PM

Sep 14 2017

marcel added a comment to D12367: do not spoil a geom label if it can not be modified via its underlying provider.

I feel that using GEOM::media as a way to signal a label change is missing the more fundamental problem: the code change is based on the assumption that labels can't change, which ae@ showed is false.

Sep 14 2017, 4:37 PM

Sep 5 2017

marcel committed rP449313: Update to openiked-1.8.
Update to openiked-1.8
Sep 5 2017, 8:14 PM
marcel closed D12190: Update to openiked-1.8.
Sep 5 2017, 8:14 PM

Aug 31 2017

marcel updated the summary of D12190: Update to openiked-1.8.
Aug 31 2017, 5:57 PM
marcel created D12190: Update to openiked-1.8.
Aug 31 2017, 5:56 PM

Aug 23 2017

marcel accepted D12104: Replace makefs' hand-rolled unescaping with strunvis..

LGTM...

Aug 23 2017, 9:18 PM
marcel added a comment to D12104: Replace makefs' hand-rolled unescaping with strunvis..

Two comments:

  1. I see that there's an unvis(3) function as well. That seems like a good way to handle escape sequences in read_word() and not have callers of read_word() handle escape characters.
  2. makefs needs to be portable. Do you know if vis(3) exists on macOS and Linux?
Aug 23 2017, 7:01 PM

Jun 9 2017

marcel added a comment to D10863: pf: Add the action structure size (in words) to the sub-header..

First the quick answer: The pf_state structure as sent by the INS, DEL and UPD actions is not a multiple of 4-bytes on amd64. All the pfsync structure are indeed.

Jun 9 2017, 1:20 AM

Jun 8 2017

marcel added a comment to D10863: pf: Add the action structure size (in words) to the sub-header..

The updated diff addresses your concern and eliminates incompatibilities. Your comment tells me that you haven't seen the updated diff...

Jun 8 2017, 4:14 PM

Jun 6 2017

marcel added a comment to D10863: pf: Add the action structure size (in words) to the sub-header..

If there are no objections, I'll commit this in a few days.

Jun 6 2017, 6:41 PM

May 23 2017

marcel updated the diff for D10863: pf: Add the action structure size (in words) to the sub-header..

Don't change the version in the header (i.e. keep at 5), and
instead use the subsequent _pad field for a revision. The
revision allows minor changes to the definitions while not
breaking compatibility with previous revisions.

May 23 2017, 4:07 PM
marcel added a comment to D10863: pf: Add the action structure size (in words) to the sub-header..

Is this part of a bigger change? What's the final goal.

May 23 2017, 3:59 PM

May 22 2017

marcel updated the test plan for D10863: pf: Add the action structure size (in words) to the sub-header..
May 22 2017, 7:58 PM
marcel added reviewers for D10863: pf: Add the action structure size (in words) to the sub-header.: jhb, glebius.
May 22 2017, 7:56 PM
marcel created D10863: pf: Add the action structure size (in words) to the sub-header..
May 22 2017, 7:54 PM

May 11 2017

marcel added inline comments to D10661: mkimg: Add flexible partition size.
May 11 2017, 2:59 PM

May 10 2017

marcel added inline comments to D10661: mkimg: Add flexible partition size.
May 10 2017, 11:04 PM
marcel added inline comments to D10661: mkimg: Add flexible partition size.
May 10 2017, 6:23 PM
marcel added inline comments to D10661: mkimg: Add flexible partition size.
May 10 2017, 3:10 PM

May 3 2017

marcel added inline comments to D10567: mkimg: Respect gpt first usable LBA.
May 3 2017, 2:57 PM

May 2 2017

marcel added inline comments to D10567: mkimg: Respect gpt first usable LBA.
May 2 2017, 6:32 PM
marcel accepted D10509: mkimg: Add maximum capacity option.

LGTM. Thanks!

May 2 2017, 6:29 PM

May 1 2017

marcel added inline comments to D10509: mkimg: Add maximum capacity option.
May 1 2017, 5:10 PM

Apr 24 2017

marcel added inline comments to D10367: mkimg: Add maximum capacity and percentage partition size.
Apr 24 2017, 3:54 PM
marcel added inline comments to D10367: mkimg: Add maximum capacity and percentage partition size.
Apr 24 2017, 3:35 PM

Apr 18 2017

marcel committed rP438813: Update to openiked-1.7.
Update to openiked-1.7
Apr 18 2017, 7:51 PM
marcel closed D10406: Upgrade OpenIKED to version 1.7 by committing rP438813: Update to openiked-1.7.
Apr 18 2017, 7:51 PM

Apr 15 2017

marcel added a reviewer for D10406: Upgrade OpenIKED to version 1.7: mat.
Apr 15 2017, 4:58 PM
marcel created D10406: Upgrade OpenIKED to version 1.7.
Apr 15 2017, 4:57 PM

Apr 12 2017

marcel added inline comments to D10367: mkimg: Add maximum capacity and percentage partition size.
Apr 12 2017, 3:52 PM

Mar 3 2017

marcel committed rP435371: Upgrade to 1.5.1. Version 1.5 is broken..
Upgrade to 1.5.1. Version 1.5 is broken.
Mar 3 2017, 10:39 PM
marcel committed rP435369: Update to openiked-1.5.
Update to openiked-1.5
Mar 3 2017, 9:38 PM

Mar 2 2017

marcel abandoned D9857: Add support for ISO C11 unnamed structure/union fields to dtrace.

Already fixed.

Mar 2 2017, 6:11 PM
marcel added a comment to D9857: Add support for ISO C11 unnamed structure/union fields to dtrace.

I'm seeing this with a slightly older 11-stable. I see that r305055 has been MFC'd as r313129 on 2017-02-02. which means the fix is not present on the system I see it in. Both my up-to-date -current and -stable systems seem to work (see example below). So it looks the problem was already fixed!

Mar 2 2017, 5:34 PM
marcel updated D9857: Add support for ISO C11 unnamed structure/union fields to dtrace.
Mar 2 2017, 6:38 AM
marcel retitled D9857: Add support for ISO C11 unnamed structure/union fields to dtrace from to Add support for ISO C11 unnamed structure/union fields to dtrace.
Mar 2 2017, 6:34 AM

Feb 27 2017

marcel accepted D9785: reg-io-width option for UART drivers.
Feb 27 2017, 4:52 PM

Feb 25 2017

marcel committed rP434844: Update to openiked-1.4.
Update to openiked-1.4
Feb 25 2017, 11:39 PM

Feb 20 2017

marcel added a comment to D9686: fix UEFI VM's bootup on Hyper-V (i.e. Hyper-V Generation-2 VM).

Going for the workaround I see! :-)

Feb 20 2017, 4:47 PM

Feb 5 2017

marcel accepted D9388: Make root_mount_hold() work after boot..
Feb 5 2017, 9:32 PM

Feb 2 2017

marcel added a comment to D9388: Make root_mount_hold() work after boot..

Got it! Thanks for the explanation.

Feb 2 2017, 12:48 AM

Jan 31 2017

marcel added a comment to D9388: Make root_mount_hold() work after boot..

First of all: You may want to change root_mount_rel() as well: h cannot be NULL anymore. A KASSERT would be appropriate...

Jan 31 2017, 6:56 PM

Jan 19 2017

marcel added a comment to D9207: Replace dot-dot relative pathing with SRCTOP/:H make manipulation where possible.

I don't want to assume I remember all the details with respect to compiling libc from a different locations, but what I recall is that it's only about building libc using a different makefile that lives in a different directory and thus having the object files go to a different object directory. Thus any mention of ${.CURDIR} had to be replaced with LIBC_SRCTOP and LIBC_SRCTOP was effectively set to ${SRCTOP}/lib/libc.

Jan 19 2017, 8:28 PM

Jan 13 2017

marcel committed rP431342: Update to openiked-1.3.
Update to openiked-1.3
Jan 13 2017, 4:32 AM

Dec 11 2016

marcel committed rS309845: MFC r309394, r309787.
MFC r309394, r309787
Dec 11 2016, 4:03 AM
marcel committed rS309844: MFC r306299:.
MFC r306299:
Dec 11 2016, 3:59 AM
marcel committed rS309843: MFC r305855, r306297, r306300, r306312-r306313.
MFC r305855, r306297, r306300, r306312-r306313
Dec 11 2016, 3:57 AM

Dec 10 2016

marcel committed rS309787: Improve upon r309394.
Improve upon r309394
Dec 10 2016, 3:31 AM

Dec 2 2016

marcel committed rS309394: Fix use-after-free bugs in pfsync(4).
Fix use-after-free bugs in pfsync(4)
Dec 2 2016, 6:16 AM
marcel closed D8671: Fix use-after-free bugs in pfsync(4) by committing rS309394: Fix use-after-free bugs in pfsync(4).
Dec 2 2016, 6:16 AM
marcel accepted D8671: Fix use-after-free bugs in pfsync(4).

Self-approved

Dec 2 2016, 6:08 AM

Nov 29 2016

marcel added reviewers for D8671: Fix use-after-free bugs in pfsync(4): kpaasial_gmail.com, bz.
Nov 29 2016, 4:24 AM
marcel retitled D8671: Fix use-after-free bugs in pfsync(4) from to Fix use-after-free bugs in pfsync(4).
Nov 29 2016, 4:21 AM

Nov 17 2016

marcel committed rP426299: Update to openiked-1.2.
Update to openiked-1.2
Nov 17 2016, 9:34 PM

Nov 15 2016

marcel committed rP426190: Update to openiked-1.1 and mark broken on FreeBSD 9.
Update to openiked-1.1 and mark broken on FreeBSD 9
Nov 15 2016, 11:31 PM

Nov 10 2016

marcel committed rP425847: Add OpenIKED, version 1.0.
Add OpenIKED, version 1.0
Nov 10 2016, 4:14 PM
marcel closed D8417: OpenIKED-1.0 by committing rP425847: Add OpenIKED, version 1.0.
Nov 10 2016, 4:14 PM
marcel added a comment to D8417: OpenIKED-1.0.

Is there anything that needs to be done, except committing this?
If finding a committer is a challenge, then I can do i myself.

Nov 10 2016, 3:41 AM

Nov 5 2016

marcel closed D8418: Don't use st_gen in struct stat by committing rS308344: Assign a random number to di_gen (for FFS), instead of extracting it.
Nov 5 2016, 4:23 PM
marcel committed rS308344: Assign a random number to di_gen (for FFS), instead of extracting it.
Assign a random number to di_gen (for FFS), instead of extracting it
Nov 5 2016, 4:23 PM
marcel accepted D8418: Don't use st_gen in struct stat.

Self approve.

Nov 5 2016, 4:23 PM

Nov 4 2016

marcel updated the diff for D8417: OpenIKED-1.0.
Nov 4 2016, 2:43 AM

Nov 3 2016

marcel updated the diff for D8417: OpenIKED-1.0.

Incorporate review comments from Mathieu.

Nov 3 2016, 8:04 PM
marcel added a comment to D8417: OpenIKED-1.0.

Great review! I very much appreciate your attention to detail!

Nov 3 2016, 7:09 PM