Page MenuHomeFreeBSD

mkimg: make MBR and EBR honor alignment, and change default alignment to 4k
AcceptedPublic

Authored by jmg on Oct 17 2019, 6:54 PM.

Details

Reviewers
imp
gjb
emaste
marcel
Group Reviewers
manpages
Summary

mkimg previously, even if you specified -P 4k, would not align
MBR images to a 4k boundary. This hasn't been necessary for MBR
for almost 20 years.

As 4k drives are very common, change mkimg to default to a 4k
alignment. I would be fine w/ uping this to 16k or 64k.
This gives images the benefit w/o having to track down all the
various scripts that make an image to fix them.

Test Plan

If you see the changes to the test program, it mounts and outputs
the gpart show info for the raw images. I used this to verify
that things are now properly aligned...

Diff Detail

Repository
rS FreeBSD src repository
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 27088
Build 25369: arc lint + arc unit

Event Timeline

jmg created this revision.Oct 17 2019, 6:54 PM
jmg added a reviewer: marcel.Oct 17 2019, 7:18 PM

Would you mind splitting the changes into 2 reviews/commits. I don't oppose the changes, but they are logically unrelated/independent and it helps us with reversals and/or MFCs if they are separate commits.

imp accepted this revision.Oct 17 2019, 9:37 PM

Would you mind splitting the changes into 2 reviews/commits. I don't oppose the changes, but they are logically unrelated/independent and it helps us with reversals and/or MFCs if they are separate commits.

My suggestion as well.

Otherwise they look good to me.

This revision is now accepted and ready to land.Oct 17 2019, 9:37 PM
jmg added a comment.Oct 17 2019, 9:46 PM

Would you mind splitting the changes into 2 reviews/commits. I don't oppose the changes, but they are logically unrelated/independent and it helps us with reversals and/or MFCs if they are separate commits.

What way do you want to split the two apart? Do you mean blksz default and mbr/ebr fixes? Or do you mean the unrelated man page changes (to make it pass igor)?

marcel accepted this revision.Oct 18 2019, 2:48 PM

As relayed via email: the changes are good. Please make them using independent commits. No need to send new reviews out. Thanks for fixing up the man page!

Copy-pasted the email sent to mjg@, since it bounced:

Heh, I didn’t even realize there were man page changes :-)
Please split them all apart. I’ll approve the review. That way you only have to commit them separately. No need to send new reviews out.