Page MenuHomeFreeBSD
Differential D5157

Patch for bug 100219
ClosedPublic
Actions

Authored by joe-thestackframe.org on Feb 1 2016, 7:30 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jun 20, 3:16 AM
Unknown Object (File)
Fri, May 24, 9:20 PM
Unknown Object (File)
May 8 2024, 12:05 PM
Unknown Object (File)
May 8 2024, 12:05 PM
Unknown Object (File)
May 8 2024, 12:05 PM
Unknown Object (File)
May 8 2024, 12:05 PM
Unknown Object (File)
May 8 2024, 9:53 AM
Unknown Object (File)
Apr 20 2024, 3:58 AM
View All 55 Files
Subscribers
None

Details

Reviewers
gnn
bz
rstone
Commits
rS307541: Limit the number of mbufs that can be allocated for IPV6_2292PKTOPTIONS
Summary

Limit the number of mbufs that can be allocated for IPV6_2292PKTOPTIONS (and IPV6_PKTOPTIONS).

Patch for bug 100219:

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=100219

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joe-thestackframe.org updated this revision to Diff 12921.Feb 1 2016, 7:30 AM
joe-thestackframe.org retitled this revision from to Patch for bug 100219.
joe-thestackframe.org updated this object.
joe-thestackframe.org edited the test plan for this revision. (Show Details)
joe-thestackframe.org added reviewers: gnn, bz.
joe-thestackframe.org added a reviewer: rstone.Jul 29 2016, 9:01 PM
rstone requested changes to this revision.Jul 30 2016, 2:33 AM
rstone edited edge metadata.
rstone added inline comments.
sys/netinet6/ip6_output.c
1382 ↗(On Diff #12921)

Should probably wrap the value in () to prevent weird order-of-operation issues from ever cropping up in the future. There isn't any in the current code but who knows how this could be used in the future.

This revision now requires changes to proceed.Jul 30 2016, 2:33 AM
joe-thestackframe.org updated this revision to Diff 21439.Oct 17 2016, 7:40 AM
joe-thestackframe.org edited edge metadata.

Add brackets around value.

joe-thestackframe.org marked an inline comment as done.Oct 17 2016, 7:42 AM
gnn accepted this revision.Oct 17 2016, 12:16 PM
gnn edited edge metadata.

Looks good to me. I can commit this if you like.

joe-thestackframe.org added a comment.Oct 17 2016, 6:09 PM
In D5157#171934, @gnn wrote:

Looks good to me. I can commit this if you like.

Yeah, that would be great. Thanks.

Closed by commit rS307541: Limit the number of mbufs that can be allocated for IPV6_2292PKTOPTIONS (authored by gnn). · Explain WhyOct 17 2016, 11:25 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
netinet6/
15 lines

Diff 21463

View Options

head/sys/netinet6/ip6_output.c

Loading...