Page MenuHomeFreeBSD

Corrected non-portable reuse of va_list in dt_printf()
AbandonedPublic

Authored by gnn on Jul 6 2016, 10:10 PM.
Tags
None
Referenced Files
Unknown Object (File)
Jan 3 2024, 9:47 AM
Unknown Object (File)
May 15 2023, 5:57 AM
Unknown Object (File)
Apr 26 2023, 3:49 PM
Unknown Object (File)
Apr 19 2023, 4:09 AM
Unknown Object (File)
Jan 10 2023, 5:05 PM
Unknown Object (File)
Jan 4 2023, 2:17 PM
Unknown Object (File)
Dec 22 2022, 4:40 PM
Unknown Object (File)
Dec 21 2022, 6:56 PM
Subscribers

Details

Reviewers
markj
jhb
rwatson
Summary

Corrected non-portable reuse of va_list in dt_printf()

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4832
Build 4893: arc lint + arc unit

Event Timeline

gnn retitled this revision from to Corrected non-portable reuse of va_list in dt_printf().
gnn updated this object.
gnn edited the test plan for this revision. (Show Details)
cddl/contrib/opensolaris/lib/libdtrace/common/dt_subr.c
678 ↗(On Diff #18197)

Don't you need the same thing here?

Address issue pointed out by markj

gnn marked an inline comment as done.Aug 2 2016, 3:19 PM

It might be better to just have a single va_copy(ap2, ap) at the beginning of the function, and just call va_end(ap2) everywhere we currently call va_end(ap). Otherwise we're doing redundant work.

cddl/contrib/opensolaris/lib/libdtrace/common/dt_subr.c
609 ↗(On Diff #18959)

Also here. :)

693 ↗(On Diff #18959)

... and here.

gnn edited edge metadata.

Remove the obsolete opebsd_poll system call.

Chuck this one because arc.