Corrected non-portable reuse of va_list in dt_printf()
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 4832 Build 4893: arc lint + arc unit
Event Timeline
cddl/contrib/opensolaris/lib/libdtrace/common/dt_subr.c | ||
---|---|---|
678 ↗ | (On Diff #18197) | Don't you need the same thing here? |
Comment Actions
It might be better to just have a single va_copy(ap2, ap) at the beginning of the function, and just call va_end(ap2) everywhere we currently call va_end(ap). Otherwise we're doing redundant work.
cddl/contrib/opensolaris/lib/libdtrace/common/dt_subr.c | ||
---|---|---|
609 ↗ | (On Diff #18959) | Also here. :) |
693 ↗ | (On Diff #18959) | ... and here. |