Page MenuHomeFreeBSD
Differential D8157

Corrected non-portable reuse of va_list in dt_printf()
ClosedPublic
Actions

Authored by gnn on Oct 5 2016, 8:59 PM.
Tags
None
Referenced Files
Unknown Object (File)
Jan 10 2024, 1:32 AM
Unknown Object (File)
Jan 9 2024, 7:31 AM
Unknown Object (File)
Dec 27 2023, 5:37 PM
Unknown Object (File)
Dec 27 2023, 5:10 PM
Unknown Object (File)
Aug 10 2023, 8:28 AM
Unknown Object (File)
Apr 13 2023, 1:46 PM
Unknown Object (File)
Apr 13 2023, 2:32 AM
Unknown Object (File)
Mar 23 2023, 4:06 PM
View All 26 Files
Subscribers
imp

Details

Reviewers
markj
bz
rstone
Commits
rS307044: Corrected non-portable reuse of va_list in dt_printf()

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

gnn updated this revision to Diff 21086.Oct 5 2016, 8:59 PM
gnn retitled this revision from to Corrected non-portable reuse of va_list in dt_printf().
gnn updated this object.
gnn edited the test plan for this revision. (Show Details)
gnn added reviewers: markj, bz.
Herald added a subscriber: imp. · View Herald TranscriptOct 5 2016, 8:59 PM
rstone accepted this revision.Oct 5 2016, 9:34 PM
rstone added a reviewer: rstone.
This revision is now accepted and ready to land.Oct 5 2016, 9:34 PM
markj added inline comments.Oct 5 2016, 9:55 PM
cddl/contrib/opensolaris/lib/libdtrace/common/dt_subr.c
609 ↗(On Diff #21086)

Need the same change here.

693 ↗(On Diff #21086)

... and here.

I think it'd be slightly cleaner to do the va_copy once at the beginning of the function.

markj added inline comments.Oct 5 2016, 9:58 PM
cddl/contrib/opensolaris/lib/libdtrace/common/dt_subr.c
693 ↗(On Diff #21086)

Hm, never mind about the single va_copy() call - ap2 might be used more than once in the same call to dt_printf().

gnn marked 2 inline comments as done.Oct 5 2016, 10:07 PM
gnn updated this revision to Diff 21088.Oct 5 2016, 10:34 PM
gnn edited edge metadata.

Address comments from markj@

This revision now requires review to proceed.Oct 5 2016, 10:34 PM
markj accepted this revision.Oct 5 2016, 11:28 PM
markj edited edge metadata.
This revision is now accepted and ready to land.Oct 5 2016, 11:28 PM
Closed by commit rS307044: Corrected non-portable reuse of va_list in dt_printf() (authored by gnn). · Explain WhyOct 11 2016, 4:12 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
cddl/
contrib/
opensolaris/
lib/
libdtrace/
common/
21 lines

Diff 21253

View Options

head/cddl/contrib/opensolaris/lib/libdtrace/common/dt_subr.c

Loading...