Differential D7309

Don't check for broadcast IPs on non-bcast pkts
ClosedPublic
Actions

Authored by rstone on Jul 25 2016, 6:06 PM.

Details

Reviewers

gnn

Group Reviewers

transport

Commits

rS304436: Don't check for broadcast IPs on non-bcast pkts

Summary

in_broadcast() can be quite expensive, so skip calling it if the
incoming mbuf wasn't sent to a broadcast L2 address in the first
place.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

rstone updated this revision to Diff 18738.Jul 25 2016, 6:06 PM

rstone retitled this revision from to Don't check for broadcast IPs on non-bcast pkts.

rstone edited the test plan for this revision. (Show Details)

rstone updated this object.

Herald added a reviewer: transport. · View Herald TranscriptJul 25 2016, 6:06 PM

Herald added a subscriber: imp. · View Herald Transcript

gnn accepted this revision.Jul 25 2016, 10:08 PM

gnn added a reviewer: gnn.

This revision is now accepted and ready to land.Jul 25 2016, 10:08 PM

Add sysctl to control new UDP receive behaviour, and document it
in UPDATING.

This revision now requires review to proceed.Aug 8 2016, 2:57 PM

gnn accepted this revision.Aug 11 2016, 4:08 PM

gnn edited edge metadata.

This revision is now accepted and ready to land.Aug 11 2016, 4:08 PM

Closed by commit rS304436: Don't check for broadcast IPs on non-bcast pkts (authored by rstone). · Explain WhyAug 18 2016, 10:59 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

UPDATING

8 lines

sys/

netinet/

udp_usrreq.c

8 lines

Diff 19472

View Options

head/UPDATING