Page MenuHomeFreeBSD
Differential D7309

Don't check for broadcast IPs on non-bcast pkts
ClosedPublic
Actions

Authored by rstone on Jul 25 2016, 6:06 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jan 15, 6:00 AM
Unknown Object (File)
Mon, Jan 6, 9:15 PM
Unknown Object (File)
Nov 25 2024, 8:29 AM
Unknown Object (File)
Oct 21 2024, 12:11 AM
Unknown Object (File)
Oct 20 2024, 7:58 PM
Unknown Object (File)
Oct 4 2024, 9:38 PM
Unknown Object (File)
Oct 4 2024, 7:34 PM
Unknown Object (File)
Oct 4 2024, 2:56 PM
View All Files
Subscribers
imp

Details

Reviewers
gnn
Group Reviewers
transport
Commits
rS304436: Don't check for broadcast IPs on non-bcast pkts
Summary

in_broadcast() can be quite expensive, so skip calling it if the
incoming mbuf wasn't sent to a broadcast L2 address in the first
place.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4612
Build 4665: arc lint + arc unit

Event Timeline

rstone updated this revision to Diff 18738.Jul 25 2016, 6:06 PM
rstone retitled this revision from to Don't check for broadcast IPs on non-bcast pkts.
rstone edited the test plan for this revision. (Show Details)
rstone updated this object.
Herald added a reviewer: transport. · View Herald TranscriptJul 25 2016, 6:06 PM
Herald added a subscriber: imp. · View Herald Transcript
gnn accepted this revision.Jul 25 2016, 10:08 PM
gnn added a reviewer: gnn.
This revision is now accepted and ready to land.Jul 25 2016, 10:08 PM
rstone updated this revision to Diff 19120.Aug 8 2016, 2:57 PM
rstone edited edge metadata.

Add sysctl to control new UDP receive behaviour, and document it
in UPDATING.

This revision now requires review to proceed.Aug 8 2016, 2:57 PM
gnn accepted this revision.Aug 11 2016, 4:08 PM
gnn edited edge metadata.
This revision is now accepted and ready to land.Aug 11 2016, 4:08 PM
Closed by commit rS304436: Don't check for broadcast IPs on non-bcast pkts (authored by rstone). · Explain WhyAug 18 2016, 10:59 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sys/
net/
3 lines
2 lines
8 lines
net80211/
5 lines
netinet/
2 lines

Diff 18738

View Options

sys/net/ethernet.h

Loading...
View Options

sys/net/if_ethersubr.c

Loading...
View Options

sys/net/if_gif.c

Loading...
View Options

sys/net80211/ieee80211_input.c

Loading...
View Options

sys/netinet/udp_usrreq.c

Loading...