Details
Details
- Reviewers
ae ngie - Commits
- rS305066: Update cryptotest for modern algorithms
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Why remove all the static from functions?
| tools/tools/crypto/cryptotest.c | ||
|---|---|---|
| 129–130 ↗ | (On Diff #19548) | Seems gratuitous unless there is a real difference. |
| 191 ↗ | (On Diff #19548) | This check can be removed; the point is to cache the crypto file descriptor, which doesn't happen if it isn't static. |
| 206 ↗ | (On Diff #19548) | This seems a little lame. What if some softfoocrypt(4) shows up? Contrived, I guess. |
Comment Actions
There is no reason for the functions to be static at all, so removing them just cleans up the code and makes it trivially debuggable.
| tools/tools/crypto/cryptotest.c | ||
|---|---|---|
| 129–130 ↗ | (On Diff #19548) | The difference is the key length and effects the benchmark. |
| 206 ↗ | (On Diff #19548) | When such a thing shows up I'll fix the benchmark code. |