Paths

Table of Contentst

Differential D7766

Add cpuset(2) support to sepearate forked processes.
ClosedPublic
Actions

Authored by gnn on Sep 2 2016, 9:14 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Jan 20, 9:20 PM

	Unknown Object (File)
	Sun, Jan 19, 9:17 PM

	Unknown Object (File)
	Thu, Jan 9, 5:41 PM

	Unknown Object (File)
	Sun, Jan 5, 7:19 AM

	Unknown Object (File)
	Sun, Dec 29, 3:09 AM

	Unknown Object (File)
	Nov 23 2024, 9:13 PM

	Unknown Object (File)
	Nov 21 2024, 1:23 AM

	Unknown Object (File)
	Nov 20 2024, 11:29 PM

View All 81 Files

Subscribers

Details

Reviewers

Commits

rS305312: Add cpuset support to separate forked processes.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

gnn updated this revision to Diff 20002.Sep 2 2016, 9:14 PM

gnn retitled this revision from to Add cpuset(2) support to sepearate forked processes..

gnn updated this object.

gnn edited the test plan for this revision. (Show Details)

Herald added a subscriber: imp. · View Herald TranscriptSep 2 2016, 9:14 PM

gnn added a reviewer: cem.Sep 2 2016, 9:14 PM

cem added inline comments.Sep 2 2016, 9:17 PM

tools/tools/crypto/cryptotest.c
469–473 ↗	(On Diff #20002)	`threads` is an arbitrary user-provided `atoi()` value and may exceed the logical range of the `cpuset_t` mask, corrupting the stack (`BIT_SET` doesn't bounds check).

gnn marked an inline comment as done.Sep 2 2016, 10:30 PM

Address issue of too many threads.

Looks good other than these nits.

tools/tools/crypto/cryptotest.c
582 ↗	(On Diff #20006)	This isn't quite right either — `sizeof(cpuset_t) * NBBY` would be closer, but I'd just use the named constant `CPU_SETSIZE` from sys/_cpuset.h.
583 ↗	(On Diff #20006)	Perhaps: `"choose fewer than %d.", ..., CPU_SETSIZE`

I've address the main issues.

tools/tools/crypto/cryptotest.c
583 ↗	(On Diff #20006)	This is a play on the old Apple compiler message: "Too many errors, make fewer."

Closed by commit rS305312: Add cpuset support to separate forked processes. (authored by gnn). · Explain WhySep 3 2016, 12:23 AM

This revision was automatically updated to reflect the committed changes.

LGTM. (I think the old compiler message only ever got notoriety because of how unhelpful it was; not something to aspire to. But whatever.)

Revision Contents
Changeset List

Path

Size

head/

tools/

tools/

crypto/

9 lines

Diff 20007

head/tools/tools/crypto/cryptotest.c

Loading...